Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/subresource_filter/core/common/PRESUBMIT.py

Issue 2844293003: Factor out UrlPatternIndex from IndexedRuleset. (Closed)
Patch Set: Address final nits. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/core/common/BUILD.gn ('k') | components/subresource_filter/core/common/document_subresource_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/core/common/PRESUBMIT.py
diff --git a/components/subresource_filter/core/common/PRESUBMIT.py b/components/subresource_filter/core/common/PRESUBMIT.py
index bb1e72ce5202b2f4b8943245185b09805f703e8b..7e054081adb2a8b124a4243d6170fbd9fe9dadc7 100644
--- a/components/subresource_filter/core/common/PRESUBMIT.py
+++ b/components/subresource_filter/core/common/PRESUBMIT.py
@@ -26,7 +26,8 @@ def CheckIndexedRulesetVersion(input_api, output_api):
continue
basename = input_api.basename(path)
- if basename.endswith('.fbs') or basename == 'indexed_ruleset.cc':
+ if (basename == 'indexed_ruleset.cc' or basename == 'url_pattern_index.cc'
+ or basename.endswith('.fbs')):
indexed_ruleset_changed = True
if basename == 'indexed_ruleset.cc':
for (_, line) in affected_file.ChangedContents():
« no previous file with comments | « components/subresource_filter/core/common/BUILD.gn ('k') | components/subresource_filter/core/common/document_subresource_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698