cc: Make images that can't possibly fit in cache not checker.

cc/tiles/image_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TILES_IMAGE_CONTROLLER_H_
 #define CC_TILES_IMAGE_CONTROLLER_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 38 matching lines @@
   virtual void UnlockImageDecode(ImageDecodeRequestId id);
 
   // This function requests that the given image be decoded and locked. Once the
   // callback has been issued, it is passed an ID, which should be used to
   // unlock this image. It is up to the caller to ensure that the image is later
   // unlocked using UnlockImageDecode.
   // Virtual for testing.
   virtual ImageDecodeRequestId QueueImageDecode(
       sk_sp<const SkImage> image,
       const ImageDecodedCallback& callback);
+  size_t image_cache_max_limit_bytes() const {
+    return image_cache_max_limit_bytes_;

[Khushal, 2017/04/28 00:12:53]

Could this just be cache_ ? cache_->GetMaximumMemoryLimit() : 0.

[vmpstr, 2017/04/28 17:18:30]

GetMaximumMemoryLimit is virtual so I just want to avoid repeated calls to it
for the case where this value is expected not to change very frequently at all.

+  }
 
  protected:
   scoped_refptr<base::SequencedTaskRunner> worker_task_runner_;
 
  private:
   struct ImageDecodeRequest {
     ImageDecodeRequest();
     ImageDecodeRequest(ImageDecodeRequestId id,
                        const DrawImage& draw_image,
                        const ImageDecodedCallback& callback,
@@ skipping 21 matching lines @@
   void ImageDecodeCompleted(ImageDecodeRequestId id);
   void GenerateTasksForOrphanedRequests();
 
   ImageDecodeCache* cache_ = nullptr;
   std::vector<DrawImage> predecode_locked_images_;
 
   static ImageDecodeRequestId s_next_image_decode_queue_id_;
   base::flat_map<ImageDecodeRequestId, DrawImage> requested_locked_images_;
 
   base::SequencedTaskRunner* origin_task_runner_ = nullptr;
+  size_t image_cache_max_limit_bytes_ = 0u;
 
   // The variables defined below this lock (aside from weak_ptr_factory_) can
   // only be accessed when the lock is acquired.
   base::Lock lock_;
   std::map<ImageDecodeRequestId, ImageDecodeRequest> image_decode_queue_;
   std::map<ImageDecodeRequestId, ImageDecodeRequest>
       requests_needing_completion_;
   bool abort_tasks_ = false;
   // Orphaned requests are requests that were either in queue or needed a
   // completion callback when we set the decode cache to be nullptr. When a new
   // decode cache is set, these requests are re-enqueued again with tasks
   // generated by the new cache. Note that when the cache is set, then aside
   // from generating new tasks, this vector should be empty.
   std::vector<ImageDecodeRequest> orphaned_decode_requests_;
 
   base::WeakPtrFactory<ImageController> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ImageController);
 };
 
 }  // namespace cc
 
 #endif  // CC_TILES_IMAGE_CONTROLLER_H_