Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2844273003: Unify the server and plugin versions of the generators (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add missed files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11601 lines, -35875 lines) Patch
M pkg/analysis_server/benchmark/integration/driver.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/input_converter.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_flutter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_scenario.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/memory_tests.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/performance_tests.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/analysis_domain.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/navigation/navigation_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 1 1 chunk +0 lines, -18663 lines 0 comments Download
D pkg/analysis_server/lib/plugin/protocol/protocol.dart View 1 1 chunk +0 lines, -598 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/protocol/protocol.dart View 1 6 chunks +9 lines, -10 lines 0 comments Download
A + pkg/analysis_server/lib/protocol/protocol_generated.dart View 1 203 chunks +11059 lines, -10798 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_manager.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/channel/channel.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/new_notifications.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 1 3 chunks +15 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/notification_manager.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/request_converter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_converter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_merger.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol/protocol_internal.dart View 1 4 chunks +21 lines, -26 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/refactoring/refactoring_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/contribution_sorter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/utilities.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/organize_directives.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/sort_members.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/source_buffer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/status.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler2.dart View 1 5 chunks +19 lines, -18 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/navigation_collector_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_implemented_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_occurrences_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/set_priority_files_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/channel/web_socket_channel_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/completion_test_support.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_util.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/organize_directives_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/statement_completion_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/analysis_options_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_library_dependencies_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_navigation_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_reachable_sources_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test2.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/lint_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/navigation_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/occurrences_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/outline_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/overrides_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/package_root_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/reanalyze_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/set_analysis_roots_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/set_general_subscriptions_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/set_priority_files_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/set_subscriptions_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_list_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_options_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/diagnostic/get_diagnostics_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/diagnostic/get_server_port_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/format_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/get_assists_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/get_fixes_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/organize_directives_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/sort_members_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/execution/create_context_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/execution/delete_context_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/execution/map_uri_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/execution/set_subscriptions_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/analysis_server/test/integration/integration_test_methods.dart View 1 1 chunk +0 lines, -1892 lines 0 comments Download
D pkg/analysis_server/test/integration/integration_tests.dart View 1 1 chunk +0 lines, -988 lines 0 comments Download
D pkg/analysis_server/test/integration/protocol_matchers.dart View 1 1 chunk +0 lines, -2349 lines 0 comments Download
M pkg/analysis_server/test/integration/search/find_element_references_test.dart View 1 4 chunks +15 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/integration/search/find_member_declarations_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/search/find_member_references_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/search/find_top_level_declarations_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/get_version_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/shutdown_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/status_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/integration/support/integration_test_methods.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
A + pkg/analysis_server/test/integration/support/integration_tests.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
A + pkg/analysis_server/test/integration/support/protocol_matchers.dart View 1 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/plugin/protocol_dart_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 1 16 chunks +29 lines, -35 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/label_contributor_test.dart View 1 2 chunks +3 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart View 1 3 chunks +5 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 1 3 chunks +5 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/override_contributor_test.dart View 1 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/organize_directives_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/sort_members_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/util_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/notification_manager_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/protocol_test_utilities.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/request_converter_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/result_converter_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/result_merger_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_core_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/stress/replay/replay.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/stress/utilities/server.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/timing/completion/completion_simple.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/timing/timing_framework.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/api.dart View 1 9 chunks +18 lines, -13 lines 0 comments Download
M pkg/analysis_server/tool/spec/check_all_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 18 chunks +55 lines, -15 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 5 chunks +13 lines, -12 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 3 chunks +2 lines, -7 lines 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_all.dart View 1 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_files View 1 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/analysis_server/tool/spec/implied_types.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/api.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/check_all_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart View 1 6 chunks +12 lines, -5 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_inttest_methods.dart View 1 6 chunks +12 lines, -7 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_matchers.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/from_html.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/generate_all.dart View 1 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/generate_files View 1 3 chunks +3 lines, -10 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/implied_types.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
There are no semantic changes in this CL. This CL back-ports the changes I made ...
3 years, 7 months ago (2017-04-27 17:08:36 UTC) #2
Brian Wilkerson
ping
3 years, 7 months ago (2017-04-28 14:27:46 UTC) #3
Brian Wilkerson
ping
3 years, 7 months ago (2017-04-28 14:27:47 UTC) #4
devoncarew
lgtm lgtm. Do the specs not need to be re-generated after these changes?
3 years, 7 months ago (2017-04-28 14:34:12 UTC) #5
Brian Wilkerson
> Do the specs not need to be re-generated after these changes? There was no ...
3 years, 7 months ago (2017-04-28 14:43:41 UTC) #6
Brian Wilkerson
3 years, 7 months ago (2017-04-28 14:46:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
e55812a3f216f075bff3e25c83b4f5527b3b66e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698