Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/ui/authentication/signin_promo_view.h

Issue 2844253003: Adding close button in SigninPromoView (Closed)
Patch Set: Merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/chrome/browser/ui/authentication/BUILD.gn ('K') | « ios/chrome/browser/ui/authentication/resources/signin_promo_dismiss_gray@3x.png ('k') | ios/chrome/browser/ui/authentication/signin_promo_view.mm » ('j') | ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/authentication/signin_promo_view.h
diff --git a/ios/chrome/browser/ui/authentication/signin_promo_view.h b/ios/chrome/browser/ui/authentication/signin_promo_view.h
index 1935e8ab490ecbe7e6d6642fa0503c8e3c3d6bd2..3374a08e9bce365d01a87e69d581237596eb529b 100644
--- a/ios/chrome/browser/ui/authentication/signin_promo_view.h
+++ b/ios/chrome/browser/ui/authentication/signin_promo_view.h
@@ -36,6 +36,7 @@ typedef NS_ENUM(NSInteger, SigninPromoViewMode) {
@property(nonatomic, readonly) UILabel* textLabel;
@property(nonatomic, readonly) MDCFlatButton* primaryButton;
@property(nonatomic, readonly) MDCFlatButton* secondaryButton;
+@property(nonatomic, readonly) UIButton* dismissButton;
msarda 2017/04/28 16:08:16 Maybe add a comment saying that this button is hid
jlebel 2017/05/03 12:41:14 Done.
// If set to YES, ShowSigninCommand is sent when primary or secondary buttons
// are tapped.
@property(nonatomic, getter=doesSendChromeCommand) BOOL sendChromeCommand;
« ios/chrome/browser/ui/authentication/BUILD.gn ('K') | « ios/chrome/browser/ui/authentication/resources/signin_promo_dismiss_gray@3x.png ('k') | ios/chrome/browser/ui/authentication/signin_promo_view.mm » ('j') | ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698