Adding close button in SigninPromoView

ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h"
 
 #include "base/logging.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "ios/chrome/browser/bookmarks/bookmarks_utils.h"
@@ skipping 396 matching lines @@
 - (UICollectionViewCell*)cellAtIndexPath:(NSIndexPath*)indexPath {
   if (indexPath.section == self.promoSection) {
     if (experimental_flags::IsSigninPromoEnabled()) {
       BookmarkSigninPromoCell* signinPromoCell = [self.collectionView
           dequeueReusableCellWithReuseIdentifier:[BookmarkSigninPromoCell
                                                      reuseIdentifier]
                                     forIndexPath:indexPath];
       signinPromoCell.signinPromoView.sendChromeCommand = YES;
       [[_signinPromoViewMediator createConfigurator]
           configureSigninPromoView:signinPromoCell.signinPromoView];
+      [signinPromoCell.signinPromoView.dismissButton
+                 addTarget:self

[lpromero, 2017/05/02 16:46:04]

I don't think it's an issue in your case, but conceptually, if the cell was
reused, would you be added twice (and thus called twice) when someone presses
the button? Should you remove yourself as a target at some point, or in
BookmarkSigninPromoCell's prepareForReuse, should you remove all targets?

[jlebel, 2017/05/03 12:41:14]

Done.

+                    action:@selector(dismissSigninPromo:)
+          forControlEvents:UIControlEventTouchUpInside];
       return signinPromoCell;
     } else {
       BookmarkPromoCell* promoCell = [self.collectionView
           dequeueReusableCellWithReuseIdentifier:[BookmarkPromoCell
                                                      reuseIdentifier]
                                     forIndexPath:indexPath];
       promoCell.delegate = self;
       return promoCell;
     }
   }
@@ skipping 83 matching lines @@
         _signinPromoViewMediator = nil;
       } else {
         _signinPromoViewMediator = [[SigninPromoViewMediator alloc] init];
         _signinPromoViewMediator.consumer = self;
       }
     }
     [self.collectionView reloadData];
   }
 }
 
+- (void)dismissSigninPromo:(id)unused {
+  [self.delegate bookmarkCollectionViewDismissPromo:self];
+}
+
 #pragma mark - BookmarkPromoCellDelegate
 
 - (void)bookmarkPromoCellDidTapSignIn:(BookmarkPromoCell*)bookmarkPromoCell {
   [self.delegate bookmarkCollectionViewShowSignIn:self];
 }
 
 - (void)bookmarkPromoCellDidTapDismiss:(BookmarkPromoCell*)bookmarkPromoCell {
   [self.delegate bookmarkCollectionViewDismissPromo:self];
 }
 
@@ skipping 18 matching lines @@
       [NSIndexPath indexPathForRow:0 inSection:self.promoSection];
   BookmarkSigninPromoCell* signinPromoCell =
       static_cast<BookmarkSigninPromoCell*>(
           [self.collectionView cellForItemAtIndexPath:indexPath]);
   if (!signinPromoCell)
     return;
   [configurator configureSigninPromoView:signinPromoCell.signinPromoView];
 }
 
 @end