Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1598)

Unified Diff: chrome/browser/io_thread.cc

Issue 284423002: Remove HttpStreamFactory's NPN/SPDY globals, except for spdy_enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/net/preconnect.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 00ff6db20f689a17f64c71d0a34b222c5e2dbc4a..b67786f243c61fe9f29d89fbb5eb81c37d67298b 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -767,18 +767,22 @@ void IOThread::InitializeNetworkOptions(const CommandLine& command_line) {
command_line.GetSwitchValueASCII(switches::kUseSpdy);
EnableSpdy(spdy_mode);
} else if (command_line.HasSwitch(switches::kEnableSpdy4)) {
- net::HttpStreamFactory::EnableNpnSpdy4Http2();
+ globals_->next_protos = net::NextProtosSpdy4Http2();
+ globals_->use_alternate_protocols.set(true);
} else if (command_line.HasSwitch(switches::kDisableSpdy31)) {
- net::HttpStreamFactory::EnableNpnSpdy3();
+ globals_->next_protos = net::NextProtosSpdy3();
+ globals_->use_alternate_protocols.set(true);
} else if (command_line.HasSwitch(switches::kEnableNpnHttpOnly)) {
- net::HttpStreamFactory::EnableNpnHttpOnly();
+ globals_->next_protos = net::NextProtosHttpOnly();
+ globals_->use_alternate_protocols.set(false);
} else {
if (spdy_trial_group == kSpdyFieldTrialDisabledGroupName &&
!command_line.HasSwitch(switches::kEnableWebSocketOverSpdy)) {
- net::HttpStreamFactory::set_spdy_enabled(false);
+ net::HttpStreamFactory::set_spdy_enabled(false);
} else {
// Use SPDY/3.1 by default.
- net::HttpStreamFactory::EnableNpnSpdy31();
+ globals_->next_protos = net::NextProtosSpdy31();
+ globals_->use_alternate_protocols.set(true);
}
}
}
@@ -821,20 +825,21 @@ void IOThread::EnableSpdy(const std::string& mode) {
net::HttpStreamFactory::set_spdy_enabled(false);
} else if (option == kDisableSSL) {
globals_->spdy_default_protocol.set(net::kProtoSPDY3);
- net::HttpStreamFactory::set_force_spdy_over_ssl(false);
- net::HttpStreamFactory::set_force_spdy_always(true);
+ globals_->force_spdy_over_ssl.set(false);
+ globals_->force_spdy_always.set(true);
} else if (option == kSSL) {
globals_->spdy_default_protocol.set(net::kProtoSPDY3);
- net::HttpStreamFactory::set_force_spdy_over_ssl(true);
- net::HttpStreamFactory::set_force_spdy_always(true);
+ globals_->force_spdy_over_ssl.set(true);
+ globals_->force_spdy_always.set(true);
} else if (option == kDisablePing) {
globals_->enable_spdy_ping_based_connection_checking.set(false);
} else if (option == kExclude) {
- net::HttpStreamFactory::add_forced_spdy_exclusion(value);
+ globals_->forced_spdy_exclusions.insert(
+ net::HostPortPair::FromURL(GURL(value)));
} else if (option == kDisableCompression) {
globals_->enable_spdy_compression.set(false);
} else if (option == kDisableAltProtocols) {
- net::HttpStreamFactory::set_use_alternate_protocols(false);
+ globals_->use_alternate_protocols.set(false);
} else if (option == kForceAltProtocols) {
net::PortAlternateProtocolPair pair;
pair.port = 443;
@@ -944,8 +949,14 @@ void IOThread::InitializeNetworkSessionParams(
&params->enable_spdy_ping_based_connection_checking);
globals_->spdy_default_protocol.CopyToIfSet(
&params->spdy_default_protocol);
- globals_->trusted_spdy_proxy.CopyToIfSet(
- &params->trusted_spdy_proxy);
+ params->next_protos = globals_->next_protos;
+ globals_->trusted_spdy_proxy.CopyToIfSet(&params->trusted_spdy_proxy);
+ globals_->force_spdy_over_ssl.CopyToIfSet(&params->force_spdy_over_ssl);
+ globals_->force_spdy_always.CopyToIfSet(&params->force_spdy_always);
+ globals_->forced_spdy_exclusions = params->forced_spdy_exclusions;
+ globals_->use_alternate_protocols.CopyToIfSet(
+ &params->use_alternate_protocols);
+
globals_->enable_quic.CopyToIfSet(&params->enable_quic);
globals_->enable_quic_https.CopyToIfSet(&params->enable_quic_https);
globals_->enable_quic_pacing.CopyToIfSet(
« no previous file with comments | « chrome/browser/io_thread.h ('k') | chrome/browser/net/preconnect.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698