Add associated binding set. Add associated_binding.html layout test.

mojo/public/js/associated_bindings.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 define("mojo/public/js/associated_bindings", [
+  "mojo/public/js/bindings",
   "mojo/public/js/core",
   "mojo/public/js/interface_types",
   "mojo/public/js/lib/interface_endpoint_client",
   "mojo/public/js/lib/interface_endpoint_handle",
-], function(core, types, interfaceEndpointClient, interfaceEndpointHandle) {
+], function(bindings, core, types, interfaceEndpointClient,
+      interfaceEndpointHandle) {
 
   var InterfaceEndpointClient = interfaceEndpointClient.InterfaceEndpointClient;
 
   // ---------------------------------------------------------------------------
 
   function makeRequest(associatedInterfacePtrInfo) {
     var {handle0, handle1} =
         interfaceEndpointHandle.createPairPendingAssociation();
 
     associatedInterfacePtrInfo.interfaceEndpointHandle = handle0;
@@ skipping 202 matching lines @@
     if (!this.isBound()) {
       return new types.AssociatedInterfaceRequest(null);
     }
 
     var result = new types.AssociatedInterfaceRequest(
         this.interfaceEndpointClient_.passHandle());
     this.close();
     return result;
   };
 
+  // ---------------------------------------------------------------------------
+
+  function AssociatedBindingSetEntry(associatedBindingSet, interfaceType, impl,

[yzshen1, 2017/04/27 17:28:38]

For function definition, please either fit all parameters on a single line (if
possible), or put each on a separate line and align them.
(There is no such requirement for function calls.)

[wangjimmy, 2017/04/27 20:26:49]

Done.

+      associatedInterfaceRequest, bindingId) {
+    this.associatedBindingSet_ = associatedBindingSet;
+    this.bindingId_ = bindingId;
+    this.associatedBinding_ = new AssociatedBinding(interfaceType, impl,
+        associatedInterfaceRequest);
+
+    this.associatedBinding_.setConnectionErrorHandler(function(reason) {
+      this.associatedBindingSet_.onConnectionError(bindingId, reason);
+    }.bind(this));
+  }
+
+  AssociatedBindingSetEntry.prototype.close = function() {
+    this.associatedBinding_.close();
+  };
+
+  function AssociatedBindingSet(interfaceType) {
+    this.interfaceType_ = interfaceType;
+    this.nextBindingId_ = 0;
+    this.bindings_ = new Map();
+    this.errorHandler_ = null;
+  }
+
+  AssociatedBindingSet.prototype = Object.create(
+      bindings.BindingSet.prototype);
+
+  AssociatedBindingSet.prototype.addBinding = function(impl,

[yzshen1, 2017/04/27 17:28:38]

Could we design BindingSetBase/BindingSetEntry to be able to handle
associated/non-associated case. And then make BindingSet/AssociatedBindingSet
inherit BindingSetBase?

It seems more robust than overriding some methods from BindingSet.

[wangjimmy, 2017/04/27 20:26:49]

Done.

+      associatedInterfaceRequest) {
+    this.bindings_.set(
+        this.nextBindingId_,
+        new AssociatedBindingSetEntry(this, this.interfaceType_, impl,
+            associatedInterfaceRequest, this.nextBindingId_));
+    ++this.nextBindingId_;
+  };
+
+  AssociatedBindingSet.prototype.constructor = AssociatedBindingSet;
+
   var exports = {};
   exports.AssociatedInterfacePtrInfo = types.AssociatedInterfacePtrInfo;
   exports.AssociatedInterfaceRequest = types.AssociatedInterfaceRequest;
   exports.makeRequest = makeRequest;
   exports.AssociatedInterfacePtrController = AssociatedInterfacePtrController;
   exports.AssociatedBinding = AssociatedBinding;
+  exports.AssociatedBindingSet = AssociatedBindingSet;
 
   return exports;
 });