Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 284413007: Navigation transitions: Exposed "setBackgroundOpaque" to ContentViewCore (Closed)

Created:
6 years, 7 months ago by shatch
Modified:
6 years, 6 months ago
Reviewers:
bulach, Sami
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Navigation transitions: Exposed "setBackgroundOpaque" to ContentViewCore The navigation transition needs the transition page to render transparently over top the current tab, so we need to expose this call to java. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274587

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
shatch
6 years, 6 months ago (2014-06-02 22:01:37 UTC) #1
bulach
lgtm (but please let sami take a quick look too, thanks!)
6 years, 6 months ago (2014-06-03 10:37:02 UTC) #2
Sami
Sorry for the delay -- I was studying your design docs :) The patch itself ...
6 years, 6 months ago (2014-06-03 14:55:59 UTC) #3
shatch
On 2014/06/03 14:55:59, Sami wrote: > Sorry for the delay -- I was studying your ...
6 years, 6 months ago (2014-06-03 15:00:08 UTC) #4
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 6 months ago (2014-06-03 16:32:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/284413007/40001
6 years, 6 months ago (2014-06-03 16:32:54 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:14:16 UTC) #7
Message was sent while issue was closed.
Change committed as 274587

Powered by Google App Engine
This is Rietveld 408576698