Fix virtual keyboard.

Fix virtual keyboard.

Virtual keyboard starts with a height of 0, which makes us wait for a frame at
that size which will never come.
RWHI will skip the resizes for this, hence will not throttle the next (correct)
size, which will come in but then be discarded.

Make sure not to create a resize lock for empty sizes.

BUG=374196
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271813

[piman, 2014-05-16 23:33:24]

https://codereview.chromium.org/284413002/diff/20001/content/browser/composit...
File content/browser/compositor/delegated_frame_host.cc (right):

https://codereview.chromium.org/284413002/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:34: #if !defined(OS_CHROMEOS)
This moved so that we can override in tests and exercise the real
ShouldCreateResizeLock.

https://codereview.chromium.org/284413002/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:104: if (desired_size ==
current_frame_size_in_dip_ || desired_size.IsEmpty())
This is the only thing that touches production.

https://codereview.chromium.org/284413002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(left):

https://codereview.chromium.org/284413002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:991:
view_->GetDelegatedFrameHost()->MaybeCreateResizeLock();
This is implicit in SetSize.

[danakj, 2014-05-20 18:20:53]

LGTM

https://codereview.chromium.org/284413002/diff/20001/content/browser/composit...
File content/browser/compositor/delegated_frame_host.h (right):

https://codereview.chromium.org/284413002/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.h:112: gfx::Size
CurrentFrameSizeInDIPForTesting() const {
does anything call this now? can it go away?

https://codereview.chromium.org/284413002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/284413002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:1040: 
extra whitespace

[piman, 2014-05-20 18:51:32]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2014-05-20 18:52:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/piman@chromium.org/284413002/60001

[piman, 2014-05-20 18:53:04]

https://codereview.chromium.org/284413002/diff/20001/content/browser/composit...
File content/browser/compositor/delegated_frame_host.h (right):

https://codereview.chromium.org/284413002/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.h:112: gfx::Size
CurrentFrameSizeInDIPForTesting() const {
On 2014/05/20 18:20:53, danakj wrote:
> does anything call this now? can it go away?

Gone, thanks.

https://codereview.chromium.org/284413002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/284413002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:1040: 
On 2014/05/20 18:20:53, danakj wrote:
> extra whitespace

Done.

[commit-bot: I haz the power, 2014-05-20 21:57:19]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-21 02:09:44]

Change committed as 271813