Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.h

Issue 2844063002: Add support for multiple simultaneous subresource_filter::Configurations. (Closed)
Patch Set: Polish + rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.h
diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.h b/components/subresource_filter/core/browser/subresource_filter_features_test_support.h
index dc06a78e204cce58f55c3d9c3f545490e661f365..df229eb03af913eaef8c0fe52574ff11679a8c13 100644
--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.h
+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.h
@@ -21,8 +21,10 @@ namespace testing {
class ScopedSubresourceFilterConfigurator {
public:
explicit ScopedSubresourceFilterConfigurator(
- scoped_refptr<ConfigurationList> configs = nullptr);
+ scoped_refptr<ConfigurationList> config_list = nullptr);
explicit ScopedSubresourceFilterConfigurator(Configuration config);
+ explicit ScopedSubresourceFilterConfigurator(
+ std::vector<Configuration> configs);
~ScopedSubresourceFilterConfigurator();
void ResetConfiguration(Configuration config);
@@ -38,8 +40,8 @@ class ScopedSubresourceFilterConfigurator {
//
// Clears the active subresource filtering configuration override, upon
// construction, if any, and restores it on destruction. So while the instance
-// is in scope, calls to GetActiveConfigurations() will default to returning the
-// hard-coded configuration corresponding to the forced feature state. Tests
+// is in scope, calls to GetEnabledConfigurations() will default to returning
+// the hard-coded configuration corresponding to the forced feature state. Tests
// that need to toggle both the feature and override the active configuration
// should therefore do so in that order.
class ScopedSubresourceFilterFeatureToggle {

Powered by Google App Engine
This is Rietveld 408576698