components/subresource_filter/core/browser/subresource_filter_features_test_support.h - Issue 2844063002: Add support for multiple simultaneous subresource_filter::Configurations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.h

Issue 2844063002: Add support for multiple simultaneous subresource_filter::Configurations. (Closed)

Patch Set: Minimal polish, still missing unittests for multiple simultaneous configs. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/core/browser/subresource_filter_features.cc ('K') | « components/subresource_filter/core/browser/subresource_filter_features.cc ('k') | components/subresource_filter/core/browser/subresource_filter_features_test_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.h

diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.h b/components/subresource_filter/core/browser/subresource_filter_features_test_support.h

index dc06a78e204cce58f55c3d9c3f545490e661f365..2f120bb9ae7e6a697a859999baf796983e4de2d3 100644

--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.h

+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.h

@@ -21,8 +21,10 @@ namespace testing {

class ScopedSubresourceFilterConfigurator {

public:

explicit ScopedSubresourceFilterConfigurator(

- scoped_refptr<ConfigurationList> configs = nullptr);

+ scoped_refptr<ConfigurationList> config_list = nullptr);

explicit ScopedSubresourceFilterConfigurator(Configuration config);

+ explicit ScopedSubresourceFilterConfigurator(

+ std::vector<Configuration> configs);

~ScopedSubresourceFilterConfigurator();

void ResetConfiguration(Configuration config);