Add support for multiple simultaneous subresource_filter::Configurations.

components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
 
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/rand_util.h"
@@ skipping 75 matching lines @@
 
 ContentSubresourceFilterDriverFactory::ContentSubresourceFilterDriverFactory(
     content::WebContents* web_contents,
     std::unique_ptr<SubresourceFilterClient> client)
     : content::WebContentsObserver(web_contents),
       client_(std::move(client)),
       throttle_manager_(
           base::MakeUnique<ContentSubresourceFilterThrottleManager>(
               this,
               client_->GetRulesetDealer(),
-              web_contents)),
-      activation_level_(ActivationLevel::DISABLED),
-      activation_decision_(ActivationDecision::UNKNOWN),
-      measure_performance_(false) {}
+              web_contents)) {}
 
 ContentSubresourceFilterDriverFactory::
     ~ContentSubresourceFilterDriverFactory() {}
 
 void ContentSubresourceFilterDriverFactory::
     OnMainResourceMatchedSafeBrowsingBlacklist(
         const GURL& url,
         const std::vector<GURL>& redirect_urls,
         safe_browsing::SBThreatType threat_type,
         safe_browsing::ThreatPatternType threat_type_metadata) {
   AddActivationListMatch(
       url, GetListForThreatTypeAndMetadata(threat_type, threat_type_metadata));
 }
 
+void ContentSubresourceFilterDriverFactory::
+    ComputeActivationForMainFrameNavigation(
+        content::NavigationHandle* navigation_handle) {
+  activation_decision_ = ActivationDecision::ACTIVATION_DISABLED;
+  activation_options_ = Configuration::ActivationOptions();
+  const auto config_list = GetEnabledConfigurations();
+  for (const auto& config : config_list->configs_by_decreasing_priority()) {
+    ActivationDecision decision =
+        ComputePerConfigActivationDecisionForMainFrameNavigation(
+            navigation_handle, config);
+    if (decision == ActivationDecision::ACTIVATED) {
+      activation_decision_ = ActivationDecision::ACTIVATED;
+      activation_options_ = config.activation_options;
+      return;
+    }
+
+    // Remember a |decision| more specific that `ACTIVATION_DISABLED`, if any.

[pkalinnikov, 2017/05/04 12:04:22]

g/that/than/

[pkalinnikov, 2017/05/04 12:04:22]

If we have 2 configs, and both return different non-disabled |decision|s, do we
not care which one returned what?

Looks hacky, but makes sense to me because this class seems only caring about
UNKNOWN, ACTIVATED and ACTIVATION_DISABLED.

[engedy, 2017/05/05 12:25:41]

Done.

[engedy, 2017/05/05 12:25:41]

Yes and yes, but agreed that it's a bit hacky. Glad to improve this if you have
any ideas.

[pkalinnikov, 2017/05/05 13:29:58]

Maybe you could add a short explicit comment that this is deliberate? E.g.:
// It doesn't matter which one of multiple possible decisions is recorded.

[engedy, 2017/05/05 19:24:10]

I cleaned this up a bit, so this is no longer a concern.

+    if (decision != ActivationDecision::ACTIVATION_DISABLED)
+      activation_decision_ = decision;
+  }
+}
+
 ContentSubresourceFilterDriverFactory::ActivationDecision
 ContentSubresourceFilterDriverFactory::
-    ComputeActivationDecisionForMainFrameNavigation(
-        content::NavigationHandle* navigation_handle) const {
+    ComputePerConfigActivationDecisionForMainFrameNavigation(
+        content::NavigationHandle* navigation_handle,
+        const Configuration& configuration) const {
   const GURL& url(navigation_handle->GetURL());
-
-  const auto configurations = GetActiveConfigurations();
-  if (configurations->the_one_and_only().activation_level ==
+  if (configuration.activation_options.activation_level ==
       ActivationLevel::DISABLED)
     return ActivationDecision::ACTIVATION_DISABLED;
 
-  if (configurations->the_one_and_only().activation_scope ==
+  if (configuration.activation_conditions.activation_scope ==
       ActivationScope::NO_SITES)
     return ActivationDecision::ACTIVATION_DISABLED;
 
   if (!url.SchemeIsHTTPOrHTTPS())
     return ActivationDecision::UNSUPPORTED_SCHEME;
+
   // TODO(csharrison): The throttle manager also performs this check. Remove
   // this one when the activation decision is sent directly to the throttle
   // manager.
   if (client_->ShouldSuppressActivation(navigation_handle))
     return ActivationDecision::URL_WHITELISTED;
 
-  switch (configurations->the_one_and_only().activation_scope) {
+  switch (configuration.activation_conditions.activation_scope) {
     case ActivationScope::ALL_SITES:
       return ActivationDecision::ACTIVATED;
     case ActivationScope::ACTIVATION_LIST: {
       // The logic to ensure only http/https URLs are activated lives in
       // AddActivationListMatch to ensure the activation list only has relevant
       // entries.
       DCHECK(url.SchemeIsHTTPOrHTTPS() ||
              !DidURLMatchActivationList(
-                 url, configurations->the_one_and_only().activation_list));
+                 url, configuration.activation_conditions.activation_list));
       bool should_activate = DidURLMatchActivationList(
-          url, configurations->the_one_and_only().activation_list);
-      if (configurations->the_one_and_only().activation_list ==
+          url, configuration.activation_conditions.activation_list);
+      if (configuration.activation_conditions.activation_list ==
           ActivationList::PHISHING_INTERSTITIAL) {
         // Handling special case, where activation on the phishing sites also
         // mean the activation on the sites with social engineering metadata.
         should_activate |= DidURLMatchActivationList(
             url, ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL);
       }
       return should_activate ? ActivationDecision::ACTIVATED
                              : ActivationDecision::ACTIVATION_LIST_NOT_MATCHED;
     }
     default:
@@ skipping 24 matching lines @@
       navigation_handle->GetNetErrorCode() != net::OK) {
     return;
   }
 
   const GURL& url = navigation_handle->GetURL();
   const content::Referrer& referrer = navigation_handle->GetReferrer();
   ui::PageTransition transition = navigation_handle->GetPageTransition();
 
   RecordRedirectChainMatchPattern();
 
-  const auto configurations = GetActiveConfigurations();
-  if (configurations->the_one_and_only().should_whitelist_site_on_reload &&
+  if (activation_options_.should_whitelist_site_on_reload &&
       NavigationIsPageReload(url, referrer, transition)) {
     // Whitelist this host for the current as well as subsequent navigations.
     client_->WhitelistInCurrentWebContents(url);
   }
 
-  activation_decision_ =
-      ComputeActivationDecisionForMainFrameNavigation(navigation_handle);
-  DCHECK(activation_decision_ != ActivationDecision::UNKNOWN);
+  ComputeActivationForMainFrameNavigation(navigation_handle);
+  DCHECK_NE(activation_decision_, ActivationDecision::UNKNOWN);
   if (activation_decision_ != ActivationDecision::ACTIVATED) {
-    ResetActivationState();
+    DCHECK_EQ(activation_options_.activation_level, ActivationLevel::DISABLED);
     return;
   }
 
-  activation_level_ = configurations->the_one_and_only().activation_level;
-  measure_performance_ =
-      activation_level_ != ActivationLevel::DISABLED &&
-      ShouldMeasurePerformanceForPageLoad(
-          configurations->the_one_and_only().performance_measurement_rate);
-  ActivationState state = ActivationState(activation_level_);
-  state.measure_performance = measure_performance_;
+  DCHECK_NE(activation_options_.activation_level, ActivationLevel::DISABLED);
+  ActivationState state = ActivationState(activation_options_.activation_level);
+  state.measure_performance = ShouldMeasurePerformanceForPageLoad(
+      activation_options_.performance_measurement_rate);
   throttle_manager_->NotifyPageActivationComputed(navigation_handle, state);
 }
 
 void ContentSubresourceFilterDriverFactory::OnFirstSubresourceLoadDisallowed() {
-  const auto configurations = GetActiveConfigurations();
-  if (configurations->the_one_and_only().should_suppress_notifications)
+  if (activation_options_.should_suppress_notifications)
     return;
-
-  client_->ToggleNotificationVisibility(activation_level_ ==
+  client_->ToggleNotificationVisibility(activation_options_.activation_level ==
                                         ActivationLevel::ENABLED);
 }
 
 bool ContentSubresourceFilterDriverFactory::ShouldSuppressActivation(
     content::NavigationHandle* navigation_handle) {
   return client_->ShouldSuppressActivation(navigation_handle);
 }
 
-void ContentSubresourceFilterDriverFactory::ResetActivationState() {
-  navigation_chain_.clear();
-  activation_list_matches_.clear();
-  activation_level_ = ActivationLevel::DISABLED;
-  measure_performance_ = false;
-}
-
 void ContentSubresourceFilterDriverFactory::DidStartNavigation(
     content::NavigationHandle* navigation_handle) {
   if (navigation_handle->IsInMainFrame() &&
       !navigation_handle->IsSameDocument()) {
     activation_decision_ = ActivationDecision::UNKNOWN;
-    ResetActivationState();
+    activation_list_matches_.clear();
+    navigation_chain_.clear();

[pkalinnikov, 2017/05/04 12:04:22]

optional: navigation_chain_.assign(1, navigation_handle->GetURL());

[engedy, 2017/05/05 12:25:41]

How about this?

[pkalinnikov, 2017/05/05 13:29:58]

Even better :)

     navigation_chain_.push_back(navigation_handle->GetURL());
     client_->ToggleNotificationVisibility(false);
   }
 }
 
 void ContentSubresourceFilterDriverFactory::DidRedirectNavigation(
     content::NavigationHandle* navigation_handle) {
   DCHECK(!navigation_handle->IsSameDocument());
   if (navigation_handle->IsInMainFrame())
     navigation_chain_.push_back(navigation_handle->GetURL());
 }
 
+void ContentSubresourceFilterDriverFactory::DidFinishNavigation(
+    content::NavigationHandle* navigation_handle) {
+  if (navigation_handle->IsInMainFrame() &&
+      !navigation_handle->IsSameDocument() &&
+      activation_decision_ == ActivationDecision::UNKNOWN &&
+      navigation_handle->HasCommitted()) {
+    activation_decision_ = ActivationDecision::ACTIVATION_DISABLED;
+    activation_options_ = Configuration::ActivationOptions();
+  }
+}
+
 bool ContentSubresourceFilterDriverFactory::DidURLMatchActivationList(
     const GURL& url,
     ActivationList activation_list) const {
   auto match_types =
       activation_list_matches_.find(DistillURLToHostAndPath(url));
   return match_types != activation_list_matches_.end() &&
          match_types->second.find(activation_list) != match_types->second.end();
 }
 
 void ContentSubresourceFilterDriverFactory::AddActivationListMatch(
@@ skipping 62 matching lines @@
       REPORT_REDIRECT_PATTERN_FOR_SUFFIX("SubresourceFilterOnly", hits_pattern,
                                          chain_size);
       break;
     default:
       NOTREACHED();
       break;
   }
 }
 
 }  // namespace subresource_filter