Chromium Code Reviews| Index: chrome/common/extensions/api/notifications.idl |
| diff --git a/chrome/common/extensions/api/notifications.idl b/chrome/common/extensions/api/notifications.idl |
| index d3cc1ac8b01399e4d11439aee7be62f87ebac02f..985148d6cb79e0ca0045f01a37dedfd790b1bfbe 100644 |
| --- a/chrome/common/extensions/api/notifications.idl |
| +++ b/chrome/common/extensions/api/notifications.idl |
| @@ -10,9 +10,11 @@ namespace notifications { |
| basic, |
| // icon, title, message, expandedMessage, image, up to two buttons |
| + [deprecated="The image will not be visible for Mac OS X users."] |
|
mkearney1
2017/04/26 23:38:58
Small nit: The image is not visible for Mac OS X u
Peter Beverloo
2017/04/27 10:30:00
Done.
|
| image, |
| - // icon, title, message, items, up to two buttons |
| + // icon, title, message, items, up to two buttons. Users on Mac OS X will |
| + // only see the first item. |
|
mkearney1
2017/04/26 23:38:58
Small nit: Users on Mac OS X only see the first it
Peter Beverloo
2017/04/27 10:30:00
Done.
|
| list, |
| // icon, title, message, progress, up to two buttons |
| @@ -44,6 +46,7 @@ namespace notifications { |
| dictionary NotificationButton { |
| DOMString title; |
| + [deprecated="Button icons will not be visible for Mac OS X users."] |
|
mkearney1
2017/04/26 23:38:58
Small nit: Button icons not visible for Mac OS X u
Peter Beverloo
2017/04/27 10:30:00
Done.
|
| DOMString? iconUrl; |
| [nodoc] NotificationBitmap? iconBitmap; |
| }; |
| @@ -64,9 +67,10 @@ namespace notifications { |
| // A URL to the app icon mask. URLs have the same restrictions as |
| // $(ref:notifications.NotificationOptions.iconUrl iconUrl). |
| - // |
| + // |
| // The app icon mask should be in alpha channel, as only the alpha channel |
| // of the image will be considered. |
| + [deprecated="The app icon mask will not be visible for Mac OS X users."] |
| DOMString? appIconMaskUrl; |
|
mkearney1
2017/04/26 23:38:57
Small nit: The app icon mask is not visible for Ma
Peter Beverloo
2017/04/27 10:30:00
Done.
|
| [nodoc] NotificationBitmap? appIconMaskBitmap; |
| @@ -98,12 +102,14 @@ namespace notifications { |
| [nodoc] DOMString? expandedMessage; |
| // A URL to the image thumbnail for image-type notifications. |
| - // URLs have the same restrictions as |
| + // URLs have the same restrictions as |
| // $(ref:notifications.NotificationOptions.iconUrl iconUrl). |
| + [deprecated="The image will not be visible for Mac OS X users."] |
| DOMString? imageUrl; |
|
mkearney1
2017/04/26 23:38:57
Small nit: The image is not visible for Mac OS X u
Peter Beverloo
2017/04/27 10:30:00
Done.
|
| [nodoc] NotificationBitmap? imageBitmap; |
| - // Items for multi-item notifications. |
| + // Items for multi-item notifications. Users on Mac OS X will only see the |
| + // first item. |
| NotificationItem[]? items; |
|
mkearney1
2017/04/26 23:38:57
Small nit: Users on Mac OS X only see the first it
Peter Beverloo
2017/04/27 10:30:00
Done.
|
| // Current progress ranges from 0 to 100. |