Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: chrome/browser/sync/engine/syncer_proto_util_unittest.cc

Issue 2844037: Fix handling of undeletion within the syncer. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Whitespace. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/syncer_proto_util.cc ('k') | chrome/browser/sync/engine/syncer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncer_proto_util_unittest.cc
diff --git a/chrome/browser/sync/engine/syncer_proto_util_unittest.cc b/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
index cfdcca6e32f40005005a779fed3356ed58867893..b33cb48237a65d83429580e66d78d8bcea43000b 100644
--- a/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
+++ b/chrome/browser/sync/engine/syncer_proto_util_unittest.cc
@@ -87,11 +87,6 @@ TEST(SyncerProtoUtil, NameExtractionOneName) {
const std::string name_a =
SyncerProtoUtil::NameFromSyncEntity(one_name_entity);
EXPECT_EQ(one_name_string, name_a);
-
- const std::string name_b =
- SyncerProtoUtil::NameFromCommitEntryResponse(one_name_response);
- EXPECT_EQ(one_name_string, name_b);
- EXPECT_TRUE(name_a == name_b);
}
TEST(SyncerProtoUtil, NameExtractionOneUniqueName) {
@@ -106,11 +101,6 @@ TEST(SyncerProtoUtil, NameExtractionOneUniqueName) {
const std::string name_a =
SyncerProtoUtil::NameFromSyncEntity(one_name_entity);
EXPECT_EQ(one_name_string, name_a);
-
- const std::string name_b =
- SyncerProtoUtil::NameFromCommitEntryResponse(one_name_response);
- EXPECT_EQ(one_name_string, name_b);
- EXPECT_TRUE(name_a == name_b);
}
// Tests NameFromSyncEntity and NameFromCommitEntryResponse when both the name
@@ -132,12 +122,6 @@ TEST(SyncerProtoUtil, NameExtractionTwoNames) {
const std::string name_a =
SyncerProtoUtil::NameFromSyncEntity(two_name_entity);
EXPECT_EQ(neuro, name_a);
-
- const std::string name_b =
- SyncerProtoUtil::NameFromCommitEntryResponse(two_name_response);
- EXPECT_EQ(neuro, name_b);
-
- EXPECT_TRUE(name_a == name_b);
}
class SyncerProtoUtilTest : public testing::Test {
@@ -237,15 +221,15 @@ TEST_F(SyncerProtoUtilTest, PostAndProcessHeaders) {
dcm.set_send_error(true);
EXPECT_FALSE(SyncerProtoUtil::PostAndProcessHeaders(&dcm, NULL,
- &msg, &response));
+ msg, &response));
dcm.set_send_error(false);
EXPECT_TRUE(SyncerProtoUtil::PostAndProcessHeaders(&dcm, NULL,
- &msg, &response));
+ msg, &response));
dcm.set_access_denied(true);
EXPECT_FALSE(SyncerProtoUtil::PostAndProcessHeaders(&dcm, NULL,
- &msg, &response));
+ msg, &response));
}
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/engine/syncer_proto_util.cc ('k') | chrome/browser/sync/engine/syncer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698