Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4106)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: rebase, address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsMetricsReporter.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java
similarity index 74%
rename from chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsMetricsReporter.java
rename to chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java
index a2e06996b115cc7bf05b95ed216d8dbc4c22457d..3743a8dc6b64be42784d58b8fcc7d85658922e0c 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsMetricsReporter.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java
@@ -7,13 +7,16 @@
import org.chromium.chrome.browser.ntp.cards.ActionItem;
import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
-import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;
+import org.chromium.chrome.browser.suggestions.SuggestionsEventReporter;
import org.chromium.chrome.browser.suggestions.SuggestionsRanker;
/**
- * Dummy implementation of {@link SuggestionsMetricsReporter} that doesn't do anything.
+ * Dummy implementation of {@link SuggestionsEventReporter} that doesn't do anything.
*/
-public class DummySuggestionsMetricsReporter implements SuggestionsMetricsReporter {
+public class DummySuggestionsEventReporter implements SuggestionsEventReporter {
+ @Override
+ public void onSurfaceOpened() {}
+
@Override
public void onPageShown(int[] categories, int[] suggestionsPerCategory) {}
@@ -21,7 +24,8 @@ public void onPageShown(int[] categories, int[] suggestionsPerCategory) {}
public void onSuggestionShown(SnippetArticle suggestion) {}
@Override
- public void onSuggestionOpened(SnippetArticle suggestion, int windowOpenDisposition) {}
+ public void onSuggestionOpened(SnippetArticle suggestion, int windowOpenDisposition,
+ SuggestionsRanker suggestionsRanker) {}
@Override
public void onSuggestionMenuOpened(SnippetArticle suggestion) {}
@@ -31,7 +35,4 @@ public void onMoreButtonShown(@CategoryInt ActionItem category) {}
@Override
public void onMoreButtonClicked(@CategoryInt ActionItem category) {}
-
- @Override
- public void setRanker(SuggestionsRanker suggestionsRanker) {}
}

Powered by Google App Engine
This is Rietveld 408576698