Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4252)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: rebase, address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/ntp/ntp_snippets_bridge.h
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.h b/chrome/browser/android/ntp/ntp_snippets_bridge.h
index 1789613256a6f397d345a459f1135d25e73a1d52..b7047d665f49d2d64701fee5a15375f5492be884 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.h
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.h
@@ -95,56 +95,6 @@ class NTPSnippetsBridge
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
- void OnPageShown(
- JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jintArray>& jcategories,
- const base::android::JavaParamRef<jintArray>& jsuggestions_per_category);
-
- void OnSuggestionShown(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- jint global_position,
- jint j_category_id,
- jint position_in_category,
- jlong publish_timestamp_ms,
- jfloat score,
- jlong fetch_timestamp_ms);
-
- void OnSuggestionOpened(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- jint global_position,
- jint j_category_id,
- jint category_index,
- jint position_in_category,
- jlong publish_timestamp_ms,
- jfloat score,
- int windowOpenDisposition);
-
- void OnSuggestionMenuOpened(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- jint global_position,
- jint j_category_id,
- jint position_in_category,
- jlong publish_timestamp_ms,
- jfloat score);
-
- void OnMoreButtonShown(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- jint j_category_id,
- jint position);
-
- void OnMoreButtonClicked(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- jint j_category_id,
- jint position);
-
- void OnNTPInitialized(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj);
- void OnColdStart(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj);
- void OnActivityWarmResumed(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj);
-
static bool Register(JNIEnv* env);
private:
« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698