chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: rebase, address comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java

index e676da0fd5e2de7edf4c916893b10e4d33455771..9a33be4defc99c731ee3bad2af34c4d41bf43278 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java

@@ -45,7 +45,8 @@

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.suggestions.ContentSuggestionsAdditionalAction;

import org.chromium.chrome.browser.suggestions.DestructionObserver;

-import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;

+import org.chromium.chrome.browser.suggestions.SuggestionsEventReporter;

+import org.chromium.chrome.browser.suggestions.SuggestionsRanker;

import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;

import org.chromium.chrome.test.util.browser.Features;

import org.chromium.chrome.test.util.browser.suggestions.ContentSuggestionsTestUtils.CategoryInfoBuilder;

@@ -76,7 +77,7 @@

@Mock

private OfflinePageBridge mOfflinePageBridge;

@Mock

- private SuggestionsMetricsReporter mMetricsReporter;

+ private SuggestionsEventReporter mEventReporter;

private FakeSuggestionsSource mSuggestionSource;

@Before

@@ -86,7 +87,8 @@ public void setUp() {

mSuggestionSource = spy(new FakeSuggestionsSource());

when(mUiDelegate.getSuggestionsSource()).thenReturn(mSuggestionSource);

- when(mUiDelegate.getMetricsReporter()).thenReturn(mMetricsReporter);

+ when(mUiDelegate.getEventReporter()).thenReturn(mEventReporter);

+ when(mUiDelegate.getSuggestionsRanker()).thenReturn(new SuggestionsRanker());

}

@After