Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: rebase, address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
index b4c346da828b43b04091726f72d4813bc192bb77..37a6b1f332d556b8297abeb2eab43541c4110737 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
@@ -24,8 +24,9 @@
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.suggestions.ContentSuggestionsAdditionalAction;
import org.chromium.chrome.browser.suggestions.DestructionObserver;
-import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;
+import org.chromium.chrome.browser.suggestions.SuggestionsEventReporter;
import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;
+import org.chromium.chrome.browser.suggestions.SuggestionsRanker;
import org.chromium.chrome.browser.suggestions.SuggestionsRecyclerView;
import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
import org.chromium.chrome.browser.widget.displaystyle.HorizontalDisplayStyle;
@@ -33,7 +34,7 @@
import org.chromium.chrome.browser.widget.displaystyle.VerticalDisplayStyle;
import org.chromium.chrome.test.ChromeActivityTestCaseBase;
import org.chromium.chrome.test.util.RenderUtils.ViewRenderer;
-import org.chromium.chrome.test.util.browser.suggestions.DummySuggestionsMetricsReporter;
+import org.chromium.chrome.test.util.browser.suggestions.DummySuggestionsEventReporter;
import org.chromium.chrome.test.util.browser.suggestions.FakeSuggestionsSource;
import java.io.IOException;
@@ -193,8 +194,9 @@ protected void setUp() throws Exception {
* A SuggestionsUiDelegate to initialize our Adapter.
*/
private class MockUiDelegate implements SuggestionsUiDelegate {
- private SuggestionsMetricsReporter mSuggestionsMetricsReporter =
- new DummySuggestionsMetricsReporter();
+ private SuggestionsEventReporter mSuggestionsEventReporter =
+ new DummySuggestionsEventReporter();
+ private SuggestionsRanker mSuggestionsRanker = new SuggestionsRanker();
@Override
public void getLocalFaviconImageForURL(
@@ -229,6 +231,11 @@ public SuggestionsSource getSuggestionsSource() {
}
@Override
+ public SuggestionsRanker getSuggestionsRanker() {
+ return mSuggestionsRanker;
+ }
+
+ @Override
public void addDestructionObserver(DestructionObserver destructionObserver) {}
@Override
@@ -237,8 +244,8 @@ public boolean isVisible() {
}
@Override
- public SuggestionsMetricsReporter getMetricsReporter() {
- return mSuggestionsMetricsReporter;
+ public SuggestionsEventReporter getEventReporter() {
+ return mSuggestionsEventReporter;
}
@Override

Powered by Google App Engine
This is Rietveld 408576698