Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4130)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: rebase, address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java
index ff9629093f35098f41a5911200aae1726311f407..37706e6c3982c3af8e18905cf3bf31a20c16568d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java
@@ -24,7 +24,8 @@
public class SuggestionsUiDelegateImpl implements SuggestionsUiDelegate {
private final List<DestructionObserver> mDestructionObservers = new ArrayList<>();
private final SuggestionsSource mSuggestionsSource;
- private final SuggestionsMetricsReporter mSuggestionsMetricsReporter;
+ private final SuggestionsRanker mSuggestionsRanker;
+ private final SuggestionsEventReporter mSuggestionsEventReporter;
private final SuggestionsNavigationDelegate mSuggestionsNavigationDelegate;
private final Profile mProfile;
@@ -37,11 +38,12 @@
private boolean mIsDestroyed;
public SuggestionsUiDelegateImpl(SuggestionsSource suggestionsSource,
- SuggestionsMetricsReporter metricsReporter,
+ SuggestionsEventReporter eventReporter,
SuggestionsNavigationDelegate navigationDelegate, Profile profile,
NativePageHost host) {
mSuggestionsSource = suggestionsSource;
- mSuggestionsMetricsReporter = metricsReporter;
+ mSuggestionsRanker = new SuggestionsRanker();
+ mSuggestionsEventReporter = eventReporter;
mSuggestionsNavigationDelegate = navigationDelegate;
mProfile = profile;
@@ -77,10 +79,15 @@ public SuggestionsSource getSuggestionsSource() {
return mSuggestionsSource;
}
+ @Override
+ public SuggestionsRanker getSuggestionsRanker() {
+ return mSuggestionsRanker;
+ }
+
@Nullable
@Override
- public SuggestionsMetricsReporter getMetricsReporter() {
- return mSuggestionsMetricsReporter;
+ public SuggestionsEventReporter getEventReporter() {
+ return mSuggestionsEventReporter;
}
@Nullable

Powered by Google App Engine
This is Rietveld 408576698