Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java |
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java |
similarity index 80% |
rename from chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java |
rename to chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java |
index b2aa548bc303bb4e1f9e813fd0a527278e2d32a2..384b3da35dad8b01b7a2c16aab4e0b8a19e1f8d2 100644 |
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java |
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java |
@@ -9,9 +9,15 @@ |
import org.chromium.chrome.browser.ntp.snippets.SnippetArticle; |
/** |
- * Exposes UMA related methods. |
+ * Exposes methods to report suggestions related events, for UMA or Fetch scheduling purposes. |
*/ |
-public interface SuggestionsMetricsReporter { |
+public interface SuggestionsEventReporter { |
+ /** |
+ * Notifies about new suggestions surfaces being opened: the bottom sheet opening or a NTP being |
+ * created. |
+ */ |
+ void onSurfaceOpened(); |
+ |
/** |
* Tracks per-page-load metrics for content suggestions. |
* @param categories The categories of content suggestions. |
@@ -30,8 +36,10 @@ |
* @param suggestion The content suggestion that the user opened. |
* @param windowOpenDisposition How the suggestion was opened (current tab, new tab, |
* new window etc). |
+ * @param suggestionsRanker The ranker used to get extra information about that suggestion. |
*/ |
- void onSuggestionOpened(SnippetArticle suggestion, int windowOpenDisposition); |
+ void onSuggestionOpened(SnippetArticle suggestion, int windowOpenDisposition, |
+ SuggestionsRanker suggestionsRanker); |
/** |
* Tracks impression metrics for the long-press menu for a content suggestion. |
@@ -50,7 +58,4 @@ |
* @param category The action button that was clicked. |
*/ |
void onMoreButtonClicked(@CategoryInt ActionItem category); |
- |
- /** Sets the ranker to use to compute some of the reported metrics. */ |
- void setRanker(SuggestionsRanker suggestionsRanker); |
} |