Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3509)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: rebase, address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java
deleted file mode 100644
index b2aa548bc303bb4e1f9e813fd0a527278e2d32a2..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java
+++ /dev/null
@@ -1,56 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.suggestions;
-
-import org.chromium.chrome.browser.ntp.cards.ActionItem;
-import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
-import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
-
-/**
- * Exposes UMA related methods.
- */
-public interface SuggestionsMetricsReporter {
- /**
- * Tracks per-page-load metrics for content suggestions.
- * @param categories The categories of content suggestions.
- * @param suggestionsPerCategory The number of content suggestions in each category.
- */
- void onPageShown(int[] categories, int[] suggestionsPerCategory);
-
- /**
- * Tracks impression metrics for a content suggestion.
- * @param suggestion The content suggestion that was shown to the user.
- */
- void onSuggestionShown(SnippetArticle suggestion);
-
- /**
- * Tracks interaction metrics for a content suggestion.
- * @param suggestion The content suggestion that the user opened.
- * @param windowOpenDisposition How the suggestion was opened (current tab, new tab,
- * new window etc).
- */
- void onSuggestionOpened(SnippetArticle suggestion, int windowOpenDisposition);
-
- /**
- * Tracks impression metrics for the long-press menu for a content suggestion.
- * @param suggestion The content suggestion for which the long-press menu was opened.
- */
- void onSuggestionMenuOpened(SnippetArticle suggestion);
-
- /**
- * Tracks impression metrics for a category's action button ("More").
- * @param category The action button that was shown.
- */
- void onMoreButtonShown(@CategoryInt ActionItem category);
-
- /**
- * Tracks click metrics for a category's action button ("More").
- * @param category The action button that was clicked.
- */
- void onMoreButtonClicked(@CategoryInt ActionItem category);
-
- /** Sets the ranker to use to compute some of the reported metrics. */
- void setRanker(SuggestionsRanker suggestionsRanker);
-}

Powered by Google App Engine
This is Rietveld 408576698