chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: address comments from treib@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

index 0a5db8d61eebe007aa233ff3d551afadeadab8f0..14fe46a71482637b1d35685023a5d3ff09293629 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

@@ -46,7 +46,7 @@

import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

import org.chromium.chrome.browser.offlinepages.OfflinePageItem;

import org.chromium.chrome.browser.suggestions.ContentSuggestionsAdditionalAction;

-import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;

+import org.chromium.chrome.browser.suggestions.SuggestionsEventReporter;

import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;

import org.chromium.chrome.browser.suggestions.SuggestionsRanker;

import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;

@@ -769,7 +769,7 @@ private static void verifyAction(

SuggestionsNavigationDelegate navDelegate = mock(SuggestionsNavigationDelegate.class);

when(manager.getSuggestionsSource()).thenReturn(suggestionsSource);

when(manager.getNavigationDelegate()).thenReturn(navDelegate);

- when(manager.getMetricsReporter()).thenReturn(mock(SuggestionsMetricsReporter.class));

+ when(manager.getEventReporter()).thenReturn(mock(SuggestionsEventReporter.class));

if (action != ContentSuggestionsAdditionalAction.NONE) {

section.getActionItemForTesting().performAction(manager);