chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: address comments from treib@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java

index 71204889839902bdd7a0faf546f3480986b00d95..a71cd9e4b43626de81977fd825c511d8fcc05311 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java

@@ -17,7 +17,7 @@

import org.chromium.chrome.browser.ntp.cards.ItemViewType;

import org.chromium.chrome.test.BottomSheetTestCaseBase;

import org.chromium.chrome.test.util.browser.RecyclerViewTestUtils;

-import org.chromium.chrome.test.util.browser.suggestions.DummySuggestionsMetricsReporter;

+import org.chromium.chrome.test.util.browser.suggestions.DummySuggestionsEventReporter;

import org.chromium.chrome.test.util.browser.suggestions.FakeSuggestionsSource;

import org.chromium.content.browser.test.util.TestTouchUtils;

@@ -32,15 +32,15 @@ protected void setUp() throws Exception {

mSuggestionsSource = new FakeSuggestionsSource();

registerCategory(mSuggestionsSource, /* category = */ 42, /* count = */ 5);

SuggestionsBottomSheetContent.setSuggestionsSourceForTesting(mSuggestionsSource);

- SuggestionsBottomSheetContent.setMetricsReporterForTesting(

- new DummySuggestionsMetricsReporter());

+ SuggestionsBottomSheetContent.setEventReporterForTesting(

+ new DummySuggestionsEventReporter());

super.setUp();

}

@Override

protected void tearDown() throws Exception {

SuggestionsBottomSheetContent.setSuggestionsSourceForTesting(null);

- SuggestionsBottomSheetContent.setMetricsReporterForTesting(null);

+ SuggestionsBottomSheetContent.setEventReporterForTesting(null);

super.tearDown();

}