chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: address comments from treib@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java

index 8e523383e91a001c56350995b8792d5a78de5a9c..b0579b6e353ebe48a67c3b7b0ca445db25b36fb8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegate.java

@@ -20,8 +20,11 @@

/** Convenience method to access the {@link SuggestionsSource}. */

SuggestionsSource getSuggestionsSource();

- /** Convenience method to access the {@link SuggestionsMetricsReporter}. */

- SuggestionsMetricsReporter getMetricsReporter();

+ /** Convenience method to access the {@link SuggestionsRanker}. */

+ SuggestionsRanker getSuggestionsRanker();

+ /** Convenience method to access the {@link SuggestionsEventReporter}. */

+ SuggestionsEventReporter getEventReporter();

/** Convenience method to access the {@link SuggestionsNavigationDelegate}. */

SuggestionsNavigationDelegate getNavigationDelegate();