chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: address comments from treib@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

index 3e8491e4fcd388c9cbc237aaeabc2a60670305ca..0fbe749f0ad9aa46576e88dbfc076e06433c5ce4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java

@@ -114,11 +114,4 @@ void fetchSuggestionFavicon(SnippetArticle suggestion, int minimumSizePx, int de

* Sets the recipient for update events from the source.

void setObserver(Observer observer);

- /**

- * Notifies the scheduler to adjust the plan due to a newly opened NTP.

- */

- // TODO(710268): This shouldn't have "NTP" in its name, as it's not specific to the NTP anymore.

- // Maybe split this off into a new interface for the scheduler?

- void onNtpInitialized();

}