chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc ('K') | « chrome/test/android/BUILD.gn ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsMetricsReporter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsMetricsReporter.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java

similarity index 79%

rename from chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsMetricsReporter.java

rename to chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java

index a2e06996b115cc7bf05b95ed216d8dbc4c22457d..1c18c4a21deccfdf991777556c364a3a1ab8b32f 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsMetricsReporter.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/DummySuggestionsEventReporter.java

@@ -7,13 +7,16 @@

import org.chromium.chrome.browser.ntp.cards.ActionItem;

import org.chromium.chrome.browser.ntp.snippets.CategoryInt;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

-import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;

+import org.chromium.chrome.browser.suggestions.SuggestionsEventReporter;

import org.chromium.chrome.browser.suggestions.SuggestionsRanker;

/**

- * Dummy implementation of {@link SuggestionsMetricsReporter} that doesn't do anything.

+ * Dummy implementation of {@link SuggestionsEventReporter} that doesn't do anything.

-public class DummySuggestionsMetricsReporter implements SuggestionsMetricsReporter {

+public class DummySuggestionsEventReporter implements SuggestionsEventReporter {

+ @Override

+ public void onSurfaceOpened() {}

@Override

public void onPageShown(int[] categories, int[] suggestionsPerCategory) {}