chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java_sources.gni ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java » ('j') | chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java

index b4c346da828b43b04091726f72d4813bc192bb77..a417110ca68f320d12607969c1f519f1e5cd1e2b 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java

@@ -24,7 +24,7 @@

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.suggestions.ContentSuggestionsAdditionalAction;

import org.chromium.chrome.browser.suggestions.DestructionObserver;

-import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;

+import org.chromium.chrome.browser.suggestions.SuggestionsEventReporter;

import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;

import org.chromium.chrome.browser.suggestions.SuggestionsRecyclerView;

import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;

@@ -193,7 +193,7 @@ protected void setUp() throws Exception {

* A SuggestionsUiDelegate to initialize our Adapter.

private class MockUiDelegate implements SuggestionsUiDelegate {

- private SuggestionsMetricsReporter mSuggestionsMetricsReporter =

+ private SuggestionsEventReporter mSuggestionsEventReporter =

new DummySuggestionsMetricsReporter();

@Override

@@ -237,8 +237,8 @@ public boolean isVisible() {

}

@Override

- public SuggestionsMetricsReporter getMetricsReporter() {

- return mSuggestionsMetricsReporter;

+ public SuggestionsEventReporter getMetricsReporter() {

+ return mSuggestionsEventReporter;

}

@Override