chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('j') | chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

index c839581dba9a823084511f241e7d86b3164b9936..f1182bd884c1275559c5b02ad7c1a3a63eeb0fb6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

@@ -148,13 +148,15 @@ public void onImpression() {

@Override

public void onCardTapped() {

int windowDisposition = WindowOpenDisposition.CURRENT_TAB;

- mUiDelegate.getMetricsReporter().onSuggestionOpened(mArticle, windowDisposition);

+ mUiDelegate.getMetricsReporter().onSuggestionOpened(

+ mArticle, windowDisposition, mUiDelegate.getSuggestionsRanker());

mUiDelegate.getNavigationDelegate().openSnippet(windowDisposition, mArticle);

}

@Override

public void openItem(int windowDisposition) {

- mUiDelegate.getMetricsReporter().onSuggestionOpened(mArticle, windowDisposition);

+ mUiDelegate.getMetricsReporter().onSuggestionOpened(

+ mArticle, windowDisposition, mUiDelegate.getSuggestionsRanker());

mUiDelegate.getNavigationDelegate().openSnippet(windowDisposition, mArticle);

}