Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2844003002: Fix few typos in the language specification. (Closed)

Created:
3 years, 8 months ago by aam
Modified:
3 years, 5 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix few typos in the language specification. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M docs/language/dartLangSpec.tex View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
aam
Hi Erik, this CR has few typo fixes. It the same changes as pull request ...
3 years, 8 months ago (2017-04-26 17:17:27 UTC) #3
eernst
On 2017/04/26 17:17:27, aam2 wrote: > Hi Erik, > > this CR has few typo ...
3 years, 8 months ago (2017-04-26 19:07:17 UTC) #4
eernst
On 2017/04/26 19:07:17, eernst wrote: > On 2017/04/26 17:17:27, aam2 wrote: > > Hi Erik, ...
3 years, 5 months ago (2017-07-14 09:51:39 UTC) #5
aam
3 years, 5 months ago (2017-07-14 13:35:44 UTC) #6
On 2017/07/14 09:51:39, eernst wrote:
> On 2017/04/26 19:07:17, eernst wrote:
> > On 2017/04/26 17:17:27, aam2 wrote:
> > > Hi Erik, 
> > >  
> > >   this CR has few typo fixes. It the same changes as pull request
> > > https://github.com/dart-lang/sdk/pull/29435, but it sounds like Rietveld
is
> > > better platform for changes review.
> > 
> > Hi Alexander,
> > 
> > thanks for the input! I'm just about to go home now and I'm on vacation the
> rest
> > of this week, but I'll look at it on Monday.
> 
> Hello again Alexander,
> 
> your fixes have been made part of a slightly broader typo fix CL 
> on the spec (https://codereview.chromium.org/2975283002/). In
> the end we had to do it like that, because our workflows around
> the language specification require a little bit more ceremony
> than we would have if we were to accept your Rietveld CL or pull
> request directly. The CL 2975283002 mentions you. Thanks again
> for the input!

Awesome, no worries!

Powered by Google App Engine
This is Rietveld 408576698