Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/android/java/res/layout/photo_picker_bitmap_view.xml

Issue 2843973002: Use larger vector graphics for special tiles and fix selection ring. (Closed)
Patch Set: Fix unused variable issue Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/drawable/circle_white.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/photo_picker_bitmap_view.xml
diff --git a/chrome/android/java/res/layout/photo_picker_bitmap_view.xml b/chrome/android/java/res/layout/photo_picker_bitmap_view.xml
index 01718226172e79a6f466476dfbc2bca3bfa3b850..bb6fabaa621f2fbf181ca9d52b0ae09d7a692020 100644
--- a/chrome/android/java/res/layout/photo_picker_bitmap_view.xml
+++ b/chrome/android/java/res/layout/photo_picker_bitmap_view.xml
@@ -24,45 +24,63 @@
android:layout_height="wrap_content"
android:contentDescription="@null" />
- <View
+ <ImageView
android:id="@+id/scrim"
android:layout_width="64dp"
android:layout_height="64dp"
android:background="@drawable/file_picker_scrim"
+ android:contentDescription="@null"
android:visibility="gone" />
</FrameLayout>
<ImageView
android:id="@+id/selected"
- android:layout_width="24dp"
- android:layout_height="24dp"
- android:layout_marginStart="4dp"
- android:layout_marginTop="4dp"
+ android:layout_width="26dp"
+ android:layout_height="26dp"
+ android:layout_marginStart="2dp"
+ android:layout_marginTop="2dp"
+ android:background="@drawable/checkmark_blue"
android:contentDescription="@null"
- android:src="@drawable/verify_checkmark"
android:visibility="gone" />
- <View
+ <ImageView
android:id="@+id/unselected"
android:layout_width="22dp"
android:layout_height="22dp"
android:layout_marginStart="4dp"
android:layout_marginTop="4dp"
android:background="@drawable/circle_white"
+ android:contentDescription="@null"
android:visibility="gone" />
<!-- Special tiles, that give access to the camera and gallery -->
- <TextView
+ <LinearLayout
android:id="@+id/special_tile"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_marginTop="@dimen/photo_picker_label_gap"
- android:drawablePadding="10dp"
- android:fontFamily="sans-serif-medium"
- android:textStyle="bold"
- android:textSize="14sp"
- android:textAllCaps="true"
- android:textColor="@color/photo_picker_special_tile_color"
+ android:orientation="vertical"
+ android:layout_gravity="center"
android:gravity="center"
- android:layout_gravity="center" />
+ android:visibility="gone">
+
+ <ImageView
+ android:id="@+id/special_tile_icon"
+ android:adjustViewBounds="true"
+ android:layout_width="48dp"
+ android:layout_height="48dp"
+ android:contentDescription="@null"
+ android:tint="@color/photo_picker_special_tile_color" />
+
+ <TextView
+ android:id="@+id/special_tile_label"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="@dimen/photo_picker_label_gap"
+ android:fontFamily="sans-serif-medium"
+ android:gravity="center"
+ android:textStyle="bold"
+ android:textSize="14sp"
+ android:textAllCaps="true"
+ android:textColor="@color/photo_picker_special_tile_color" />
+ </LinearLayout>
</view>
« no previous file with comments | « chrome/android/java/res/drawable/circle_white.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698