Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 284393002: Remove unused shell_app_window_api.h/cc (Closed)

Created:
6 years, 7 months ago by James Cook
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove unused shell_app_window_api.h/cc This was replaced by the stub in apps/shell/browser/api/shell/ and the chrome.shell.createWindow implementation. BUG=none TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -116 lines) Patch
D apps/shell/browser/shell_app_window_api.h View 1 chunk +0 lines, -31 lines 0 comments Download
D apps/shell/browser/shell_app_window_api.cc View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
James Cook
rockot, PTAL. Please CQ if looks good.
6 years, 7 months ago (2014-05-16 21:12:31 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 7 months ago (2014-05-16 21:14:55 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-05-16 21:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/284393002/1
6 years, 7 months ago (2014-05-16 21:15:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 06:45:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 07:32:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154779)
6 years, 7 months ago (2014-05-17 07:32:29 UTC) #7
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-05-17 16:06:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/284393002/1
6 years, 7 months ago (2014-05-17 16:06:58 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 20:09:16 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 21:22:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154819)
6 years, 7 months ago (2014-05-17 21:22:42 UTC) #12
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 7 months ago (2014-05-18 18:46:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/284393002/1
6 years, 7 months ago (2014-05-18 18:46:24 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-18 19:37:02 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 21:01:26 UTC) #16
Message was sent while issue was closed.
Change committed as 271314

Powered by Google App Engine
This is Rietveld 408576698