Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Issue 2843853002: Making BindingManager work on the launcher thread only. (Closed)
Patch Set: Added a comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/LauncherThread.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
diff --git a/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java b/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
index f10218ba97cf9029e2bac1985f070d04a19d26d4..42578238305513ab3cb7e24e3ef3b90c16606d7e 100644
--- a/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
+++ b/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
@@ -297,7 +297,7 @@ public class BindingManagerImplTest {
}
/**
- * Verifies that the initial binding is removed after determinedVisibility() is called.
+ * Verifies that the initial binding is removed after onDeterminedVisibility() is called.
*/
@Test
@Feature({"ProcessManagement"})
@@ -315,8 +315,8 @@ public class BindingManagerImplTest {
// Verify that the initial binding is held.
Assert.assertTrue(connection.isInitialBindingBound());
- // Call determinedVisibility() and verify that the initial binding was released.
- manager.determinedVisibility(connection.getPid());
+ // Call onDeterminedVisibility() and verify that the initial binding was released.
+ manager.onDeterminedVisibility(connection.getPid());
Assert.assertFalse(connection.isInitialBindingBound());
}
}
@@ -344,7 +344,7 @@ public class BindingManagerImplTest {
// After initial binding is removed, the connection is no longer oom protected.
manager.setInForeground(connection.getPid(), false);
- manager.determinedVisibility(connection.getPid());
+ manager.onDeterminedVisibility(connection.getPid());
ShadowLooper.runUiThreadTasksIncludingDelayedTasks();
Assert.assertFalse(message, connection.isOomProtectedOrWasWhenDied());
@@ -624,7 +624,7 @@ public class BindingManagerImplTest {
Assert.assertFalse(connection.isModerateBindingBound());
manager.setInForeground(connection.getPid(), false);
- manager.determinedVisibility(connection.getPid());
+ manager.onDeterminedVisibility(connection.getPid());
Assert.assertFalse(connection.isInitialBindingBound());
Assert.assertTrue(connection.isModerateBindingBound());
}
@@ -647,7 +647,7 @@ public class BindingManagerImplTest {
Assert.assertFalse(connection.isModerateBindingBound());
manager.setInForeground(connection.getPid(), true);
- manager.determinedVisibility(connection.getPid());
+ manager.onDeterminedVisibility(connection.getPid());
Assert.assertFalse(connection.isInitialBindingBound());
Assert.assertTrue(connection.isStrongBindingBound());
Assert.assertFalse(connection.isModerateBindingBound());
@@ -667,7 +667,7 @@ public class BindingManagerImplTest {
connection.start(null /* startCallback */);
manager.addNewConnection(connection.getPid(), connection);
manager.setInForeground(connection.getPid(), false);
- manager.determinedVisibility(connection.getPid());
+ manager.onDeterminedVisibility(connection.getPid());
Assert.assertTrue(connection.isModerateBindingBound());
manager.onSentToBackground();
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/LauncherThread.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698