Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chromeos/network/onc/onc_merger.cc

Issue 2843813002: Remove SetWithoutPathExpansion (Closed)
Patch Set: Fix CrOS Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_mapper.cc ('k') | chromeos/network/onc/onc_translator_onc_to_shill.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_merger.cc
diff --git a/chromeos/network/onc/onc_merger.cc b/chromeos/network/onc/onc_merger.cc
index 41c6b5807ee89e13a9cc7b8a3169451ec6de8bec..83653bdf9b19749abc8ef95a1e56bfc08df15739 100644
--- a/chromeos/network/onc/onc_merger.cc
+++ b/chromeos/network/onc/onc_merger.cc
@@ -76,8 +76,8 @@ DictionaryPtr GetEditableFlags(const base::DictionaryValue& policy) {
continue;
}
- result_editable->SetWithoutPathExpansion(
- it.key(), GetEditableFlags(*child_policy).release());
+ result_editable->SetWithoutPathExpansion(it.key(),
+ GetEditableFlags(*child_policy));
}
return result_editable;
}
@@ -139,7 +139,7 @@ class MergeListOfDictionaries {
}
if (merged_value)
- result->SetWithoutPathExpansion(key, merged_value.release());
+ result->SetWithoutPathExpansion(key, std::move(merged_value));
}
}
return result;
@@ -415,7 +415,8 @@ class MergeToAugmented : public MergeToEffective {
if (values.active_setting) {
augmented_value->SetWithoutPathExpansion(
- ::onc::kAugmentationActiveSetting, values.active_setting->DeepCopy());
+ ::onc::kAugmentationActiveSetting,
+ values.active_setting->CreateDeepCopy());
}
if (!which_effective.empty()) {
@@ -430,22 +431,24 @@ class MergeToAugmented : public MergeToEffective {
if (!is_credential) {
if (values.user_policy) {
augmented_value->SetWithoutPathExpansion(
- ::onc::kAugmentationUserPolicy, values.user_policy->DeepCopy());
+ ::onc::kAugmentationUserPolicy,
+ values.user_policy->CreateDeepCopy());
}
if (values.device_policy) {
augmented_value->SetWithoutPathExpansion(
::onc::kAugmentationDevicePolicy,
- values.device_policy->DeepCopy());
+ values.device_policy->CreateDeepCopy());
}
}
if (values.user_setting) {
augmented_value->SetWithoutPathExpansion(
- ::onc::kAugmentationUserSetting, values.user_setting->DeepCopy());
+ ::onc::kAugmentationUserSetting,
+ values.user_setting->CreateDeepCopy());
}
if (values.shared_setting) {
augmented_value->SetWithoutPathExpansion(
::onc::kAugmentationSharedSetting,
- values.shared_setting->DeepCopy());
+ values.shared_setting->CreateDeepCopy());
}
if (HasUserPolicy() && values.user_editable) {
augmented_value->SetBooleanWithoutPathExpansion(
« no previous file with comments | « chromeos/network/onc/onc_mapper.cc ('k') | chromeos/network/onc/onc_translator_onc_to_shill.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698