Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Unified Diff: base/values.h

Issue 2843783003: Expose Value::GetList and Value(ListStorage) on ListValue (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index 99b30fc67cd0276d06e5ae1f36d1e0fb195ad777..3cec9e9e7b7a4614311627f4a5e0b0f41caea7c6 100644
--- a/base/values.h
+++ b/base/values.h
@@ -383,6 +383,8 @@ class BASE_EXPORT ListValue : public Value {
static std::unique_ptr<ListValue> From(std::unique_ptr<Value> value);
ListValue();
+ explicit ListValue(const ListStorage& in_list);
+ explicit ListValue(ListStorage&& in_list) noexcept;
// Clears the contents of this ListValue
void Clear();
@@ -430,6 +432,8 @@ class BASE_EXPORT ListValue : public Value {
bool GetBinary(size_t index, Value** out_value);
bool GetDictionary(size_t index, const DictionaryValue** out_value) const;
bool GetDictionary(size_t index, DictionaryValue** out_value);
+
+ using Value::GetList;
bool GetList(size_t index, const ListValue** out_value) const;
bool GetList(size_t index, ListValue** out_value);
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698