Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: device/usb/usb_device_handle_usbfs.h

Issue 2843613002: Fix crash when closing a device from a USB transfer timeout (Closed)
Patch Set: Address mcasas@ nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/usb_device_handle_unittest.cc ('k') | device/usb/usb_device_handle_usbfs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/usb_device_handle_usbfs.h
diff --git a/device/usb/usb_device_handle_usbfs.h b/device/usb/usb_device_handle_usbfs.h
index a9bf1e274aa563eb4e7d928d511a056a16640661..e8aa06373832c5164a5ba03b670ff2ef1e3f948f 100644
--- a/device/usb/usb_device_handle_usbfs.h
+++ b/device/usb/usb_device_handle_usbfs.h
@@ -134,6 +134,7 @@ class UsbDeviceHandleUsbfs : public UsbDeviceHandle {
const UsbDeviceHandle::IsochronousTransferCallback& callback,
UsbTransferStatus status);
void SetUpTimeoutCallback(Transfer* transfer, unsigned int timeout);
+ void OnTimeout(Transfer* transfer);
std::unique_ptr<Transfer> RemoveFromTransferList(Transfer* transfer);
void CancelTransfer(Transfer* transfer, UsbTransferStatus status);
void DiscardUrbBlocking(Transfer* transfer);
@@ -158,6 +159,7 @@ class UsbDeviceHandleUsbfs : public UsbDeviceHandle {
std::unique_ptr<FileThreadHelper> helper_;
std::list<std::unique_ptr<Transfer>> transfers_;
+ base::SequenceChecker sequence_checker_;
};
} // namespace device
« no previous file with comments | « device/usb/usb_device_handle_unittest.cc ('k') | device/usb/usb_device_handle_usbfs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698