tools/chrome_proxy/webdriver/common.py - Issue 2843463004: Add variations combinations testing framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/webdriver/common.py

Issue 2843463004: Add variations combinations testing framework (Closed)

Patch Set: fix merge issue 3 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_proxy/webdriver/common.py

diff --git a/tools/chrome_proxy/webdriver/common.py b/tools/chrome_proxy/webdriver/common.py

index 4dfc2fa0d3ffb1a11e25fa234ccc400312dd71b7..2143f6e9dd9b883b1329ce44ce9f74793a69e523 100644

--- a/tools/chrome_proxy/webdriver/common.py

+++ b/tools/chrome_proxy/webdriver/common.py

@@ -166,7 +166,8 @@ class TestDriver:

# Override flags given in code with any command line arguments.

for override_arg in shlex.split(self._flags.browser_args):

arg_key = GetDictKey(override_arg)

- if arg_key in original_args:

+ if (arg_key in original_args

+ and original_args[arg_key] in self._chrome_args):

self._chrome_args.remove(original_args[arg_key])

self._logger.info('Removed Chrome flag. %s', original_args[arg_key])

self._chrome_args.add(override_arg)

« no previous file with comments | « no previous file | tools/chrome_proxy/webdriver/variations_combinations.py » ('j') | no next file with comments »