Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

Issue 2843433004: Remove WebInputMethodControllerImpl::suppress_next_keypress_event_ (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebInputMethodControllerImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
index 18e8f0b26fa6e6fe463115aec468d3b9e766d040..bff1b861c4a44a433953624a3d4c374dc6d0fed8 100644
--- a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
@@ -27,7 +27,7 @@ namespace blink {
WebInputMethodControllerImpl::WebInputMethodControllerImpl(
WebLocalFrameImpl* web_local_frame)
- : web_local_frame_(web_local_frame), suppress_next_keypress_event_(false) {}
+ : web_local_frame_(web_local_frame) {}
WebInputMethodControllerImpl::~WebInputMethodControllerImpl() {}
@@ -77,15 +77,6 @@ bool WebInputMethodControllerImpl::SetComposition(
return false;
}
- // A keypress event is canceled. If an ongoing composition exists, then the
- // keydown event should have arisen from a handled key (e.g., backspace).
- // In this case we ignore the cancellation and continue; otherwise (no
- // ongoing composition) we exit and signal success only for attempts to
- // clear the composition.
- if (suppress_next_keypress_event_ &&
- !GetInputMethodController().HasComposition())
- return text.IsEmpty();
-
UserGestureIndicator gesture_indicator(DocumentUserGestureToken::Create(
GetFrame()->GetDocument(), UserGestureToken::kNewGesture));
« no previous file with comments | « third_party/WebKit/Source/web/WebInputMethodControllerImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698