Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4660)

Unified Diff: cc/trees/proxy_main.cc

Issue 2843433003: cc: Remove slow BeginMainFrame dump. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/proxy_main.cc
diff --git a/cc/trees/proxy_main.cc b/cc/trees/proxy_main.cc
index c11036c3ff32bae611bc372f7bfaf85f502ede71..6b06f0ee80f91d92fd2b2bef533f8db11074df21 100644
--- a/cc/trees/proxy_main.cc
+++ b/cc/trees/proxy_main.cc
@@ -266,17 +266,7 @@ void ProxyMain::BeginMainFrame(
base::Unretained(proxy_impl_.get()), &completion,
layer_tree_host_, begin_main_frame_start_time,
hold_commit_for_activation));
- // TODO(sunnyps): Remove this code once crbug.com/668892 is fixed.
- // content/common/content_constants_internal.cc defines hung renderer delay
- // as 30s so choose something less than that but still sufficiently long.
- static constexpr base::TimeDelta kDumpDelay =
- base::TimeDelta::FromSeconds(20);
- if (!completion.TimedWait(kDumpDelay)) {
- ImplThreadTaskRunner()->PostTask(
- FROM_HERE, base::BindOnce(&ProxyImpl::DumpForBeginMainFrameHang,
- base::Unretained(proxy_impl_.get())));
- completion.Wait();
- }
+ completion.Wait();
}
current_pipeline_stage_ = NO_PIPELINE_STAGE;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698