Elimate NOTIFICATION_GOOGLE_URL_UPDATED

Elimate NOTIFICATION_GOOGLE_URL_UPDATED

This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED
notification to instead register a callback with GoogleURLTracker and
eliminates the notification. It also migrate the GoogleURLTracker unittest from
listening for the notification to listening for the callback.

BUG=373261, 373237
TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271313

[Peter Kasting, 2014-05-16 23:23:45]

Do any listeners actually care what the old Google URL is?  If none do, let's
just eliminate that from the callback until someone actually needs it.

LGTM otherwise.

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:64: 
Nit: Preserve two blank lines here

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/ui/naviga...
File chrome/browser/ui/navigation_correction_tab_observer.h (right):

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/ui/naviga...
chrome/browser/ui/navigation_correction_tab_observer.h:52:
content::NotificationRegistrar registrar_;
This can go away

[blundell, 2014-05-17 11:25:36]

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:64: 
On 2014/05/16 23:23:45, Peter Kasting wrote:
> Nit: Preserve two blank lines here

Done.

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/ui/naviga...
File chrome/browser/ui/navigation_correction_tab_observer.h (right):

https://codereview.chromium.org/284343003/diff/20001/chrome/browser/ui/naviga...
chrome/browser/ui/navigation_correction_tab_observer.h:52:
content::NotificationRegistrar registrar_;
On 2014/05/16 23:23:45, Peter Kasting wrote:
> This can go away

Done.

[blundell, 2014-05-17 11:30:56]

On 2014/05/16 23:23:45, Peter Kasting wrote:
> Do any listeners actually care what the old Google URL is?  If none do, let's
> just eliminate that from the callback until someone actually needs it.
> 
> LGTM otherwise.
> 

TemplateURLService cares.

>
https://codereview.chromium.org/284343003/diff/20001/chrome/browser/google/go...
> File chrome/browser/google/google_url_tracker_unittest.cc (right):
> 
>
https://codereview.chromium.org/284343003/diff/20001/chrome/browser/google/go...
> chrome/browser/google/google_url_tracker_unittest.cc:64: 
> Nit: Preserve two blank lines here
> 
>
https://codereview.chromium.org/284343003/diff/20001/chrome/browser/ui/naviga...
> File chrome/browser/ui/navigation_correction_tab_observer.h (right):
> 
>
https://codereview.chromium.org/284343003/diff/20001/chrome/browser/ui/naviga...
> chrome/browser/ui/navigation_correction_tab_observer.h:52:
> content::NotificationRegistrar registrar_;
> This can go away

[blundell, 2014-05-18 07:58:03]

TBR=thakis for chrome_notification_types

[blundell, 2014-05-18 07:58:08]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-18 07:58:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/284343003/40001

[commit-bot: I haz the power, 2014-05-18 08:24:06]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-18 08:26:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-18 08:26:56]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[blundell, 2014-05-18 09:25:38]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-18 09:25:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/284343003/60001

[commit-bot: I haz the power, 2014-05-18 11:15:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-18 12:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-18 12:15:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[blundell, 2014-05-18 18:57:36]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-18 18:57:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/284343003/60001

[commit-bot: I haz the power, 2014-05-18 19:51:05]

Change committed as 271313

[Nico, 2014-05-19 00:51:20]

A revert of this CL has been created in
https://codereview.chromium.org/294563002/ by thakis@chromium.org.

The reason for reverting is: speculative, browser_tests stated timing out on all
non-dbg win main waterfall test bots, with a message such as


E:\b\depot_tools\python276_bin\python_slave.exe
E:\b\build\scripts\slave\runisolatedtest.py --test_name browser_tests
--builder_name "Win7 Tests (1)" --checkout_dir
E:\b\build\slave\Win7_Tests__1_\build
E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe --
E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe
--brave-new-test-launcher --test-launcher-bot-mode
--test-launcher-total-shards=3 --test-launcher-shard-index=0 --lib=browser_tests
--gtest_print_time
--gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml
--test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9

E:\b\depot_tools\python276_bin\python_slave.exe
E:\b\build\slave\Win7_Tests__1_\build\src\tools\swarming_client\isolate.py run
--isolated
E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.isolated -v
-- --no-cr --test-launcher-bot-mode --test-launcher-total-shards=3
--test-launcher-shard-index=0
--gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml
--test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
 INFO         isolate(685):
CompleteState.load_isolate(E:\b\build\slave\Win7_Tests__1_\build,
E:\b\build\slave\Win7_Tests__1_\build\src\chrome\browser_tests.isolate, {}, {},
{'EXECUTABLE_SUFFIX': '.exe'}, False)
 INFO         isolate(156):
normalize_path_variables(E:\b\build\slave\Win7_Tests__1_\build, {},
E:\b\build\slave\Win7_Tests__1_\build\src\chrome)
 INFO  isolate_format( 57):
determine_root_dir(E:\b\build\slave\Win7_Tests__1_\build\src\chrome, 80 files)
-> E:\b\build\slave\Win7_Tests__1_\build\src
 INFO         isolate( 84):
recreate_tree(outdir=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl,
indir=E:\b\build\slave\Win7_Tests__1_\build\src, files=9443, action=4,
as_hash=False)
 INFO         isolate(1266): Running
['E:\\b\\depot_tools\\python276_bin\\python_slave.exe',
'../testing/test_env.py', u'..\\out\\Release/browser_tests.exe',
'--test-launcher-bot-mode', '--no-cr', '--test-launcher-bot-mode',
'--test-launcher-total-shards=3', '--test-launcher-shard-index=0',
'--gtest_output=xml:E:\\b\\build\\slave\\Win7_Tests__1_\\build\\gtest-results\\browser_tests\\browser_tests.xml',
'--test-launcher-summary-output=c:\\users\\chrome~2\\appdata\\local\\temp\\tmpfbmzn9'],
cwd=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl\chrome

command timed out: 600 seconds without output, attempting to kill
program finished with exit code 1.