Issue 2843423002: Fix hot dynamic check in WhereIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2843423002: Fix hot dynamic check in WhereIterator (Closed)

Created:
3 years, 7 months ago by vsm

Modified:
3 years, 7 months ago

Reviewers:
floitsch, Jacob

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix hot dynamic check in WhereIterator R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/aa3966dc84dcbbd6865ceffa09c038ea5406cf6a

Patch Set 1 #

Total comments: 1

Created: 3 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View		Binary file		0 comments	Download
	M	sdk/lib/internal/iterable.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

https://codereview.chromium.org/2843423002/diff/1/sdk/lib/internal/iterable.dart File sdk/lib/internal/iterable.dart (right): https://codereview.chromium.org/2843423002/diff/1/sdk/lib/internal/iterable.dart#newcode438 sdk/lib/internal/iterable.dart:438: if (_f(_iterator.current)) { The change above removes the dynamic ...

3 years, 7 months ago (2017-04-27 13:29:28 UTC) #2

vsm

3 years, 7 months ago (2017-04-27 13:35:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aa3966dc84dcbbd6865ceffa09c038ea5406cf6a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages