Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3663)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu_animation.h

Issue 2843413003: [Views] App Menu Icon Update (Closed)
Patch Set: Fix for isherman Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/app_menu_animation.h
diff --git a/chrome/browser/ui/views/toolbar/app_menu_animation.h b/chrome/browser/ui/views/toolbar/app_menu_animation.h
index 1ff69ee156621f0d50fbe03cf856f9c46ddb6afc..839202b58d35b2e5a5db16ec179847c5d60c5440 100644
--- a/chrome/browser/ui/views/toolbar/app_menu_animation.h
+++ b/chrome/browser/ui/views/toolbar/app_menu_animation.h
@@ -20,7 +20,7 @@ class AppMenuButton;
// This class is used for animating and drawing the app menu icon.
class AppMenuAnimation : public gfx::AnimationDelegate {
public:
- AppMenuAnimation(AppMenuButton* owner, bool should_animate_closed);
+ AppMenuAnimation(AppMenuButton* owner, SkColor initial_color);
~AppMenuAnimation() override;
@@ -28,7 +28,9 @@ class AppMenuAnimation : public gfx::AnimationDelegate {
void PaintAppMenu(gfx::Canvas* canvas, const gfx::Rect& bounds);
// Updates the icon colors.
msw 2017/04/28 21:39:12 nit: s/colors/color.
spqchan 2017/04/29 00:36:33 Removed the comment since it's a setter (and self
- void SetIconColors(SkColor start_color, SkColor severity_color);
+ void set_severity_color(SkColor severity_color) {
+ severity_color_ = severity_color;
+ }
// Starts the animation if it's not already running.
void StartAnimation();
@@ -70,9 +72,6 @@ class AppMenuAnimation : public gfx::AnimationDelegate {
AppMenuButton* const owner_;
- // True if the animation should close after it finishes opening.
- const bool should_animate_closed_;
-
std::unique_ptr<gfx::SlideAnimation> animation_;
AppMenuDot bottom_dot_;

Powered by Google App Engine
This is Rietveld 408576698