Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2843413003: [Views] App Menu Icon Update (Closed)
Patch Set: Fix for isherman Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 ash::switches::kAshForceTabletModeTouchView}, 554 ash::switches::kAshForceTabletModeTouchView},
555 {flag_descriptions::kForceTabletModeClamshell, 555 {flag_descriptions::kForceTabletModeClamshell,
556 ash::switches::kAshForceTabletMode, 556 ash::switches::kAshForceTabletMode,
557 ash::switches::kAshForceTabletModeClamshell}, 557 ash::switches::kAshForceTabletModeClamshell},
558 {flag_descriptions::kForceTabletModeAuto, 558 {flag_descriptions::kForceTabletModeAuto,
559 ash::switches::kAshForceTabletMode, 559 ash::switches::kAshForceTabletMode,
560 ash::switches::kAshForceTabletModeAuto}, 560 ash::switches::kAshForceTabletModeAuto},
561 }; 561 };
562 #endif // OS_CHROMEOS 562 #endif // OS_CHROMEOS
563 563
564 #if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \
565 defined(OS_WIN)
566 const FeatureEntry::Choice kAppMenuIconChoices[] = {
567 {flags_ui::kGenericExperimentChoiceDefault, "", ""},
568 {flag_descriptions::kAppMenuIconOldBehavior, switches::kAppMenuIcon,
569 switches::kAppMenuIconOldBehavior},
570 {flag_descriptions::kAppMenuIconPersistentOpenedState,
571 switches::kAppMenuIcon, switches::kAppMenuIconPersistentOpenedState},
572 {flag_descriptions::kAppMenuIconPersistentClosedState,
573 switches::kAppMenuIcon, switches::kAppMenuIconPersistentClosedState},
574 };
575 #endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
576 // defined(OS_WIN)
577
578 #if defined(OS_ANDROID) 564 #if defined(OS_ANDROID)
579 const FeatureEntry::FeatureParam 565 const FeatureEntry::FeatureParam
580 kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = { 566 kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
581 {ntp_snippets::kCategoryOrderParameter, 567 {ntp_snippets::kCategoryOrderParameter,
582 ntp_snippets::kCategoryOrderGeneral}, 568 ntp_snippets::kCategoryOrderGeneral},
583 }; 569 };
584 570
585 const FeatureEntry::FeatureParam 571 const FeatureEntry::FeatureParam
586 kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = { 572 kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = {
587 {ntp_snippets::kCategoryOrderParameter, 573 {ntp_snippets::kCategoryOrderParameter,
(...skipping 2044 matching lines...) Expand 10 before | Expand all | Expand 10 after
2632 {"new-omnibox-answer-types", flag_descriptions::kNewOmniboxAnswerTypesName, 2618 {"new-omnibox-answer-types", flag_descriptions::kNewOmniboxAnswerTypesName,
2633 flag_descriptions::kNewOmniboxAnswerTypesDescription, kOsAll, 2619 flag_descriptions::kNewOmniboxAnswerTypesDescription, kOsAll,
2634 FEATURE_VALUE_TYPE(omnibox::kNewOmniboxAnswerTypes)}, 2620 FEATURE_VALUE_TYPE(omnibox::kNewOmniboxAnswerTypes)},
2635 2621
2636 #if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \ 2622 #if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \
2637 defined(OS_WIN) 2623 defined(OS_WIN)
2638 {"omnibox-entity-suggestions", 2624 {"omnibox-entity-suggestions",
2639 flag_descriptions::kOmniboxEntitySuggestionsName, 2625 flag_descriptions::kOmniboxEntitySuggestionsName,
2640 flag_descriptions::kOmniboxEntitySuggestionsDescription, kOsDesktop, 2626 flag_descriptions::kOmniboxEntitySuggestionsDescription, kOsDesktop,
2641 FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)}, 2627 FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)},
2642 {"app-menu-icon", flag_descriptions::kAppMenuIconName, 2628 {"enable-new-app-menu-icon", flag_descriptions::kEnableNewAppMenuIconName,
2643 flag_descriptions::kAppMenuIconDescription, kOsDesktop, 2629 flag_descriptions::kEnableNewAppMenuIconDescription, kOsDesktop,
2644 MULTI_VALUE_TYPE(kAppMenuIconChoices)}, 2630 SINGLE_VALUE_TYPE(switches::kEnableNewAppMenuIcon)},
2645 #endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || 2631 #endif // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
2646 // defined(OS_WIN) 2632 // defined(OS_WIN)
2647 2633
2648 #if defined(OS_ANDROID) 2634 #if defined(OS_ANDROID)
2649 {"enable-custom-feedback-ui", 2635 {"enable-custom-feedback-ui",
2650 flag_descriptions::kEnableCustomFeedbackUiName, 2636 flag_descriptions::kEnableCustomFeedbackUiName,
2651 flag_descriptions::kEnableCustomFeedbackUiDescription, kOsAndroid, 2637 flag_descriptions::kEnableCustomFeedbackUiDescription, kOsAndroid,
2652 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)}, 2638 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)},
2653 #endif // OS_ANDROID 2639 #endif // OS_ANDROID
2654 2640
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
2988 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2974 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2989 2975
2990 const FeatureEntry* GetFeatureEntries(size_t* count) { 2976 const FeatureEntry* GetFeatureEntries(size_t* count) {
2991 *count = arraysize(kFeatureEntries); 2977 *count = arraysize(kFeatureEntries);
2992 return kFeatureEntries; 2978 return kFeatureEntries;
2993 } 2979 }
2994 2980
2995 } // namespace testing 2981 } // namespace testing
2996 2982
2997 } // namespace about_flags 2983 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698