Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: telemetry/telemetry/story/expectations_unittest.py

Issue 2843403005: [Telemetry] Add Expectation module that enables disabling benchmarks/stories (Closed)
Patch Set: [Telemetry] Have benchmarks have story expectations. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/story/expectations.py ('k') | telemetry/telemetry/testing/fakes/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/story/expectations_unittest.py
diff --git a/telemetry/telemetry/story/expectations_unittest.py b/telemetry/telemetry/story/expectations_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..00eec143cddefe40cc7a40a924829985e7f5c603
--- /dev/null
+++ b/telemetry/telemetry/story/expectations_unittest.py
@@ -0,0 +1,157 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import unittest
+
+from telemetry.story import expectations
+from telemetry.testing import fakes
+
+
+class MockState(object):
+ def __init__(self):
+ self.platform = fakes.FakePlatform()
+
+
+class MockStory(object):
+ def __init__(self, name):
+ self._name = name
+
+ @property
+ def display_name(self):
+ return self._name
+
+
+class TestConditionTest(unittest.TestCase):
+
+ def setUp(self):
+ self._platform = fakes.FakePlatform()
+
+ def testAllAlwaysReturnsTrue(self):
+ self.assertTrue(expectations.ALL.ShouldDisable(self._platform))
+
+ def testAllWinReturnsTrueOnWindows(self):
+ self._platform.SetOSName('win')
+ self.assertTrue(expectations.ALL_WIN.ShouldDisable(self._platform))
+
+ def testAllWinReturnsFalseOnOthers(self):
+ self._platform.SetOSName('not_windows')
+ self.assertFalse(expectations.ALL_WIN.ShouldDisable(self._platform))
+
+ def testAllLinuxReturnsTrueOnLinux(self):
+ self._platform.SetOSName('linux')
+ self.assertTrue(expectations.ALL_LINUX.ShouldDisable(self._platform))
+
+ def testAllLinuxReturnsFalseOnOthers(self):
+ self._platform.SetOSName('not_linux')
+ self.assertFalse(expectations.ALL_LINUX.ShouldDisable(self._platform))
+
+ def testAllMacReturnsTrueOnMac(self):
+ self._platform.SetOSName('mac')
+ self.assertTrue(expectations.ALL_MAC.ShouldDisable(self._platform))
+
+ def testAllMacReturnsFalseOnOthers(self):
+ self._platform.SetOSName('not_mac')
+ self.assertFalse(expectations.ALL_MAC.ShouldDisable(self._platform))
+
+ def testAllAndroidReturnsTrueOnAndroid(self):
+ self._platform.SetOSName('android')
+ self.assertTrue(expectations.ALL_ANDROID.ShouldDisable(self._platform))
+
+ def testAllAndroidReturnsFalseOnOthers(self):
+ self._platform.SetOSName('not_android')
+ self.assertFalse(expectations.ALL_ANDROID.ShouldDisable(self._platform))
+
+ def testAllDesktopReturnsFalseOnNonDesktop(self):
+ false_platforms = ['android']
+ for plat in false_platforms:
+ self._platform.SetOSName(plat)
+ self.assertFalse(expectations.ALL_DESKTOP.ShouldDisable(self._platform))
+
+ def testAllDesktopReturnsTrueOnDesktop(self):
+ true_platforms = ['win', 'mac', 'linux']
+ for plat in true_platforms:
+ self._platform.SetOSName(plat)
+ self.assertTrue(expectations.ALL_DESKTOP.ShouldDisable(self._platform))
+
+ def testAllMobileReturnsFalseOnNonMobile(self):
+ false_platforms = ['win', 'mac', 'linux']
+ for plat in false_platforms:
+ self._platform.SetOSName(plat)
+ self.assertFalse(expectations.ALL_MOBILE.ShouldDisable(self._platform))
+
+ def testAllMobileReturnsTrueOnMobile(self):
+ true_platforms = ['android']
+ for plat in true_platforms:
+ self._platform.SetOSName(plat)
+ self.assertTrue(expectations.ALL_MOBILE.ShouldDisable(self._platform))
+
+
+class StoryExpectationsTest(unittest.TestCase):
+ def setUp(self):
+ self.platform = fakes.FakePlatform()
+
+ def testCantDisableAfterInit(self):
+ e = expectations.StoryExpectations()
+ with self.assertRaises(AssertionError):
+ e.DisableBenchmark(['test'], 'test')
+ with self.assertRaises(AssertionError):
+ e.DisableStory('story', ['platform'], 'reason')
+
+ def testDisableBenchmark(self):
+ class FooExpectations(expectations.StoryExpectations):
+ def SetExpectations(self):
+ self.DisableBenchmark([expectations.ALL_WIN], 'crbug.com/123')
+
+ e = FooExpectations()
+ self.platform.SetOSName('win')
+
+ reason = e.IsBenchmarkDisabled(self.platform)
+ self.assertEqual(reason, 'crbug.com/123')
+
+ self.platform.SetOSName('android')
+ reason = e.IsBenchmarkDisabled(self.platform)
+ self.assertIsNone(reason)
+
+ def testDisableStoryMultipleConditions(self):
+ class FooExpectations(expectations.StoryExpectations):
+ def SetExpectations(self):
+ self.DisableStory(
+ 'multi', [expectations.ALL_WIN], 'crbug.com/123')
+ self.DisableStory(
+ 'multi', [expectations.ALL_MAC], 'crbug.com/456')
+
+ e = FooExpectations()
+
+ self.platform.SetOSName('mac')
+ reason = e.IsStoryDisabled(
+ MockStory('multi'), self.platform)
+ self.assertEqual(reason, 'crbug.com/456')
+
+ def testDisableStoryOneCondition(self):
+ class FooExpectations(expectations.StoryExpectations):
+ def SetExpectations(self):
+ self.DisableStory(
+ 'disable', [expectations.ALL_WIN], 'crbug.com/123')
+
+ e = FooExpectations()
+
+ self.platform.SetOSName('win')
+ reason = e.IsStoryDisabled(
+ MockStory('disable'), self.platform)
+ self.assertEqual(reason, 'crbug.com/123')
+ self.platform.SetOSName('mac')
+ reason = e.IsStoryDisabled(
+ MockStory('disabled'), self.platform)
+ self.assertFalse(reason)
+ self.assertIsNone(reason)
+
+ def testDisableStoryWithLongName(self):
+ class FooExpectations(expectations.StoryExpectations):
+ def SetExpectations(self):
+ self.DisableStory(
+ '123456789012345678901234567890123456789012345678901',
+ [expectations.ALL], 'Too Long')
+
+ with self.assertRaises(AssertionError):
+ FooExpectations()
« no previous file with comments | « telemetry/telemetry/story/expectations.py ('k') | telemetry/telemetry/testing/fakes/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698