telemetry/telemetry/benchmark_unittest.py - Issue 2843403005: [Telemetry] Add Expectation module that enables disabling benchmarks/stories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/benchmark_unittest.py

Issue 2843403005: [Telemetry] Add Expectation module that enables disabling benchmarks/stories (Closed)

Patch Set: 30 -> 50 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/benchmark_unittest.py

diff --git a/telemetry/telemetry/benchmark_unittest.py b/telemetry/telemetry/benchmark_unittest.py

index cb23c6f18eaf4508bda61e026940755d8728ae8c..ad5a97967c1743ae52c708bbd0505b56f8d2bbbe 100644

--- a/telemetry/telemetry/benchmark_unittest.py

+++ b/telemetry/telemetry/benchmark_unittest.py

@@ -159,3 +159,10 @@ class BenchmarkTest(unittest.TestCase):

story_runner.Run = original_run_fn

self.assertTrue(validPredicate[0])

+ def testBenchmarkExpectations(self):

+ b = TestBenchmark(story_module.Story(

+ shared_state_class=shared_page_state.SharedPageState))

+ expectations = b.GetExpectations()

+ self.assertIsInstance(

+ expectations, story_module.expectations.StoryExpectations)

charliea (OOO until 10-5) 2017/05/15 21:15:41 possible suggestion: just inline b.GetExpectations

rnephew (Reviews Here) 2017/05/15 21:36:06 Done.