Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/mb/mb_config.pyl

Issue 2843403004: Revert of Ensure that builders that use goma strip absolute paths by default. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index 8756ee578f2d2ebb310a11e4bee2ad036481db2f..9284e4d55691f1cfc7e1abdf877fdab62584e0c5 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -1729,10 +1729,7 @@
'goma': {
# The MB code will properly escape goma_dir if necessary in the GYP
# code path; the GN code path needs no escaping.
- # We also set strip_absolute_paths to ensure that we can get deterministic
- # builds. This isn't just on by default when goma is on so that devs
- # can do goma builds but still be able to debug by default.
- 'gn_args': 'use_goma=true strip_absolute_paths_from_debug_symbols=true',
+ 'gn_args': 'use_goma=true',
},
'gpu_fyi_tests': {
@@ -1783,7 +1780,7 @@
},
'minimal_symbols': {
- 'gn_args': 'symbol_level=1',
+ 'gn_args': 'symbol_level=1 strip_absolute_paths_from_debug_symbols=true',
},
'mipsel': {
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698