Move ownership of PowerSaveBlocker from WakeLockServiceContext to WakeLockServiceImpl

device/wake_lock/wake_lock_service_context.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_WAKE_LOCK_WAKE_LOCK_SERVICE_CONTEXT_H_
 #define DEVICE_WAKE_LOCK_WAKE_LOCK_SERVICE_CONTEXT_H_
 
 #include <memory>
 #include <set>
 #include <utility>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/sequenced_task_runner.h"
 #include "device/wake_lock/public/interfaces/wake_lock_context.mojom.h"
 #include "device/wake_lock/wake_lock_service_impl.h"
 #include "mojo/public/cpp/bindings/binding.h"
-#include "mojo/public/cpp/bindings/interface_request.h"
 #include "mojo/public/cpp/bindings/strong_binding_set.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace device {
 
 class PowerSaveBlocker;
 
 // Callback that maps a context ID to the NativeView associated with
 // that context. This callback is provided to the Device Service by its
 // embedder.
@@ skipping 12 matching lines @@
 class WakeLockServiceContext : public mojom::WakeLockContext {
  public:
   WakeLockServiceContext(
       mojom::WakeLockContextRequest request,
       int context_id,
       scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
       const WakeLockContextCallback& native_view_getter);
   ~WakeLockServiceContext() override;
 
   // mojom::WakeLockContext:
-  void GetWakeLock(
-      mojo::InterfaceRequest<mojom::WakeLockService> request) override;
+  void GetWakeLock(device::PowerSaveBlocker::PowerSaveBlockerType type,
+                   device::PowerSaveBlocker::Reason reason,
+                   const std::string& description,
+                   mojom::WakeLockServiceRequest request) override;
   void HasWakeLockForTests(

[blundell, 2017/05/02 11:27:43]

IIUC, the only reason that this class still has any complexity is because of
this method. Let's move this method into WakeLockService; the browsertest can
access it by accessing the WebContent's |blink_wake_lock_|. Then this class
(i.e., WakeLockServiceContext) becomes dead-simple: it just has a StrongBinding
to its request, it doesn't need to track the WakeLockServiceImpls at all;
WakeLockServiceImpl can instead have a BindingSet to manage all its requests and
delete itself when that binding set becomes empty.

[ke.he, 2017/05/04 11:54:14]

Done.

       const HasWakeLockForTestsCallback& callback) override;
-
-  // Requests wake lock.
-  void RequestWakeLock();
-
-  // Cancels pending wake lock request.
-  void CancelWakeLock();
+  void IncreaseWakeLockCount();
+  void DecreaseWakeLockCount();
 
  private:
-  void CreateWakeLock();
-  void RemoveWakeLock();
-  void UpdateWakeLock();
   void OnContextBindingError();
 
   // Checks whether this instance is still needed, and if not, destroys it.
   void DestroyIfNoLongerNeeded();
 
-  scoped_refptr<base::SequencedTaskRunner> main_task_runner_;
   scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;
 
-  int num_lock_requests_;
+  // Counts number of wake lock instances, for test usage.
+  int wake_lock_count_;
 
-  // The actual power save blocker for screen.
-  std::unique_ptr<PowerSaveBlocker> wake_lock_;
-
-#if defined(OS_ANDROID)
   int context_id_;
   WakeLockContextCallback native_view_getter_;
-#endif
 
   mojo::Binding<mojom::WakeLockContext> context_binding_;
   bool context_binding_encountered_error_;
 
   mojo::StrongBindingSet<mojom::WakeLockService> wake_lock_bindings_;
 
   DISALLOW_COPY_AND_ASSIGN(WakeLockServiceContext);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_WAKE_LOCK_WAKE_LOCK_SERVICE_CONTEXT_H_