device/wake_lock/public/interfaces/wake_lock_service.mojom - Issue 2843353003: Move ownership of PowerSaveBlocker from WakeLockServiceContext to WakeLockServiceImpl

Side by Side Diff: device/wake_lock/public/interfaces/wake_lock_service.mojom

Issue 2843353003: Move ownership of PowerSaveBlocker from WakeLockServiceContext to WakeLockServiceImpl (Closed)

Patch Set: correct some trivial #includes Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « device/wake_lock/public/interfaces/wake_lock_context.mojom ('k') | device/wake_lock/wake_lock_context_provider.cc » ('j') | device/wake_lock/wake_lock_service_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module device.mojom;	5 module device.mojom;

6	6

7 // WebLockService receives wake lock preferences from its client.	7 // WebLockService receives wake lock preferences from its client.

8 interface WakeLockService {	8 interface WakeLockService {

	9 // Request WakeLock Service from WakeLockServiceImpl.
	blundell 2017/05/05 12:49:37 nit: I would write something like: "Requests that nit: I would write something like: "Requests that a wake lock be applied on behalf of this client. Has no effect if the client has previously called this method without subsequently calling RequestWakeLock()." ke.he 2017/05/05 14:56:36 Thanks very much. I'm sorry for my poor english. " Show quoted text On 2017/05/05 12:49:37, blundell wrote: > nit: I would write something like: > > "Requests that a wake lock be applied on behalf of this client. Has no effect if > the client has previously called this method without subsequently calling > RequestWakeLock()." Thanks very much. I'm sorry for my poor english. "subsequently calling RequestWakeLock()" -> "subsequently calling CancelWakeLock()", right?
	10 // Each WakeLockServiceImpl instance owns only 1 PowerSaveBlocker.

	11 // If client calls RequestWakeLock() multiple times consecutively,

	12 // WakeLockServiceImpl only handles the first one.

9 RequestWakeLock();	13 RequestWakeLock();

	14

	15 // Cancel WakeLock Service.
	blundell 2017/05/05 12:49:37 "Cancels any outstanding wake lock request from th "Cancels any outstanding wake lock request from this client. If there are no more outstanding requests from any clients, the active wake lock (if there is one) will be turned off)." ke.he 2017/05/05 14:56:36 Done. Show quoted text On 2017/05/05 12:49:37, blundell wrote: > "Cancels any outstanding wake lock request from this client. If there are no > more outstanding requests from any clients, the active wake lock (if there is > one) will be turned off)." Done.
10 CancelWakeLock();	16 CancelWakeLock();

	17

	18 // Add other clients to current WakeLockServiceImpl so it can serve multiple
	blundell 2017/05/05 12:49:37 "Adds a client to this WakeLockService instance. C "Adds a client to this WakeLockService instance. Clients are grouped on a per-WakeLockService instance basis: that is, a given WakeLockService instance turns on its wake lock whenever any of its clients make a request to do so and turns off its wake lock only when all its clients that had previously called RequestWakelock() cancel their requests." ke.he 2017/05/05 14:56:36 Done. Show quoted text On 2017/05/05 12:49:37, blundell wrote: > "Adds a client to this WakeLockService instance. Clients are grouped on a > per-WakeLockService instance basis: that is, a given WakeLockService instance > turns on its wake lock whenever any of its clients make a request to do so and > turns off its wake lock only when all its clients that had previously called > RequestWakelock() cancel their requests." Done.
	19 // clients.

	20 AddClient(WakeLockService& wake_lock);

	21

	22 // Test-only method that returns whether a wake lock is currently active.

	23 HasWakeLockForTests() => (bool result);

11 };	24 };

OLD	NEW