Issue 2843343002: [dart:io] Make Platform.localeName fall back on en_US if LANG is not defined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2843343002: [dart:io] Make Platform.localeName fall back on en_US if LANG is not defined (Closed)

Created:
3 years, 8 months ago by zra

Modified:
3 years, 7 months ago

Reviewers:
P.Y.L.

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Alan Knight

Target Ref:
refs/heads/master

Visibility:
Public.

[dart:io] Make Platform.localeName fall back on en_US if LANG is not defined LANG is not defined on Fuchsia buildbots, causing some build-breakage. R=pylaligand@google.com Committed: https://github.com/dart-lang/sdk/commit/be9c9f223771c74fe199ce174ddd8421fc99f772

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -3 lines)			Patch
M	runtime/bin/platform_android.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/bin/platform_fuchsia.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/bin/platform_linux.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

zra

3 years, 7 months ago (2017-04-27 06:22:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
be9c9f223771c74fe199ce174ddd8421fc99f772 (presubmit successful).