Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2843333005: Extend pkg/front_end/lib/src/fasta/kernel/verifier.dart to check for UnknownType. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extend pkg/front_end/lib/src/fasta/kernel/verifier.dart to check for UnknownType. UnknownType should only ever appear in the type schemas used by type inference; it should not show up in a completed program. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/748e7c8deddaaf3613a0a40a85cbb5b5ae8e3531

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M pkg/front_end/front_end.iml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/verifier.dart View 4 chunks +12 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 7 months ago (2017-04-27 15:57:58 UTC) #2
ahe
lgtm https://codereview.chromium.org/2843333005/diff/1/pkg/front_end/lib/src/fasta/kernel/verifier.dart File pkg/front_end/lib/src/fasta/kernel/verifier.dart (right): https://codereview.chromium.org/2843333005/diff/1/pkg/front_end/lib/src/fasta/kernel/verifier.dart#newcode49 pkg/front_end/lib/src/fasta/kernel/verifier.dart:49: printUnexpected(Uri.parse(fileUri), node?.fileOffset ?? 0, "$error"); -1.
3 years, 7 months ago (2017-04-27 16:38:20 UTC) #3
Paul Berry
https://codereview.chromium.org/2843333005/diff/1/pkg/front_end/lib/src/fasta/kernel/verifier.dart File pkg/front_end/lib/src/fasta/kernel/verifier.dart (right): https://codereview.chromium.org/2843333005/diff/1/pkg/front_end/lib/src/fasta/kernel/verifier.dart#newcode49 pkg/front_end/lib/src/fasta/kernel/verifier.dart:49: printUnexpected(Uri.parse(fileUri), node?.fileOffset ?? 0, "$error"); On 2017/04/27 16:38:20, ahe ...
3 years, 7 months ago (2017-04-27 16:43:52 UTC) #4
Paul Berry
3 years, 7 months ago (2017-04-27 16:58:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
748e7c8deddaaf3613a0a40a85cbb5b5ae8e3531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698