components/cronet/android/test/proguard.cfg - Issue 2843293002: Switched to new versions of netty and tcnative

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/proguard.cfg

Issue 2843293002: Switched to new versions of netty and tcnative (Closed)

Patch Set: Added Http2Server certificate constants to the test base class. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/test/proguard.cfg

diff --git a/components/cronet/android/test/proguard.cfg b/components/cronet/android/test/proguard.cfg

index 6b5ce51a0d67baab38b6d19f895f8db276dcbd8f..8beae8ec176dd6df3ff6fb666dde283bb2e192d9 100644

--- a/components/cronet/android/test/proguard.cfg

+++ b/components/cronet/android/test/proguard.cfg

@@ -20,3 +20,6 @@

-keep class org.chromium.base.test.util.**

-keep class org.chromium.net.TestFilesInstaller

-keep class org.chromium.net.MetricsTestUtil

+# A netty-tcnative class that is only called from the native code.

+-keep class org.apache.tomcat.jni.CertificateRequestedCallback$KeyMaterial { *; }

mef 2017/04/27 18:54:19 nit: maybe move it up to io.netty classes and add

kapishnikov 2017/04/27 19:45:08 I re-ran the tests and it looks that this "keep" w